Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding a loading spinner, mostly #6

Merged
merged 2 commits into from Aug 17, 2011
Merged

adding a loading spinner, mostly #6

merged 2 commits into from Aug 17, 2011

Conversation

paulirish
Copy link
Contributor

  • we use a data uri loading spinner GIF that is added to the controls bar while the image loads.
  • the convert.php on slideshare that this runs through seems to be VERYYYY slow but once the slides are in their image cache, they seem to be fine.. not much we can do about that.
  • i also hardcoded the aspect ratio for the slides.. sometimes a failed image meant the controls jumped to the top.. i've also seen an image go wayyy too high. so now we enforce a height on the image. i don't see where this will be a problem, but let me know if you think so.

thanks again for this project! i love it.

codepo8 added a commit that referenced this pull request Aug 17, 2011
adding a loading spinner, mostly
@codepo8 codepo8 merged commit 94e7e4e into codepo8:master Aug 17, 2011
@codepo8
Copy link
Owner

codepo8 commented Aug 17, 2011

You spin me right round...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants