Skip to content

Commit

Permalink
vscode: Fix update check timeouts
Browse files Browse the repository at this point in the history
Forgot an extra 60 in the check interval and the notification timeout.
Very unfortunate. Check has been allowed every 168 minutes instead of
every week.
  • Loading branch information
nhooyr committed Nov 30, 2020
1 parent cc18175 commit 0713fa9
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions ci/dev/vscode.patch
Expand Up @@ -988,7 +988,7 @@ index 0000000000000000000000000000000000000000..ead6a3cd5e98fdde074f19ee5043f152
+ const lastNoti = storageService.getNumber('csLastUpdateNotification', StorageScope.GLOBAL);
+ if (lastNoti) {
+ // Only remind them again after 1 week.
+ const timeout = 1000*60*24*7;
+ const timeout = 1000*60*60*24*7;
+ const threshold = lastNoti + timeout;
+ if (Date.now() < threshold) {
+ return;
Expand All @@ -1007,7 +1007,7 @@ index 0000000000000000000000000000000000000000..ead6a3cd5e98fdde074f19ee5043f152
+ logService.debug(`failed to check for update: ${error}`);
+ }).finally(() => {
+ // Check again every 6 hours.
+ setTimeout(updateLoop, 1000*60*6);
+ setTimeout(updateLoop, 1000*60*60*6);
+ });
+ };
+
Expand Down

0 comments on commit 0713fa9

Please sign in to comment.