GitHub login redirect fails due to missing subpath

[Nick-Hopps]

OS/Web Information

• Web Browser: Firefox
• Local OS: Windows10
• Remote OS: Ubuntu 20.04
• Remote Architecture: amd64
• code-server --version: 3.11.1

Steps to Reproduce

1. click the link:
2. The page shows 404 not found.
3. Login failed.

Expected

Login to github without failing.

Actual

Failed logining into GitHub.

Logs

Screenshot

Notes

This issue can be reproduced in VS Code: No

[Nick-Hopps]

I'm using code-server under reverse proxy, which is handled by Nginx, My config is:

server {
    listen 8080;
    server_name xxx.com;

    location /code-server/ {
        proxy_set_header Host $host;
        proxy_set_header Upgrade $http_upgrade;
        proxy_set_header Connection upgrade;
        proxy_pass http://10.0.0.1:8000/;
    }
}

[Nick-Hopps]

After investigation, I found that it was the authentication URL which lead to the failing:

https://xxx.com/callback?vscode-requestId=......

It suppose to be:

https://xxx.com/code-server/callback?vscode-requestId=......

Is there any workaroud to deal with such situation? I've tried some but failed.

[jsjoeio]

For whatever reason, I can't seem to find the "Sign in with GitHub" from GitLens.

If it's the authentication URL, you should be able to modify it manually:

see #1883 (comment)

Let me know if that works!

[Nick-Hopps]

Here is the entrance:

I've tried that approach, but it results in Bad Request.

[Nick-Hopps]

For the origin URL:

When adding my subpath "/code-server/" to the host name:

Since the page shows the expected result(however nothing happened to code-server), so I think maybe fix the request URL may help.

[jsjoeio]

Thanks for the screenshots!

So I clicked on that, it asked for a PAT, I copied one from https://github.com/settings/tokens and it worked? Can you try that approach instead of the auth URL callback?

[Nick-Hopps]

Wow, it works for me! Thx very much. If only callback also works, it'd be perfect.

[jsjoeio]

I'll let @code-asher chime in and see if he is able to reproduce the issue with the callback

[Nick-Hopps]

waiting for good news 😄

[code-asher]

Ah yup there is a bug where the redirect URL does not include the sub-path. It should be a simple fix but I have not had the chance to look into it.