GitHub login redirect fails due to missing subpath

[Nick-Hopps]

OS/Web Information

• Web Browser: Firefox
• Local OS: Windows10
• Remote OS: Ubuntu 20.04
• Remote Architecture: amd64
• code-server --version: 3.11.1

Steps to Reproduce

1. click the link:
2. The page shows 404 not found.
3. Login failed.

Expected

Login to github without failing.

Actual

Failed logining into GitHub.

Logs

Screenshot

Notes

This issue can be reproduced in VS Code: No

[Nick-Hopps]

I'm using code-server under reverse proxy, which is handled by Nginx, My config is:

server {
    listen 8080;
    server_name xxx.com;

    location /code-server/ {
        proxy_set_header Host $host;
        proxy_set_header Upgrade $http_upgrade;
        proxy_set_header Connection upgrade;
        proxy_pass http://10.0.0.1:8000/;
    }
}

[Nick-Hopps]

After investigation, I found that it was the authentication URL which lead to the failing:

https://xxx.com/callback?vscode-requestId=......

It suppose to be:

https://xxx.com/code-server/callback?vscode-requestId=......

Is there any workaroud to deal with such situation? I've tried some but failed.

[jsjoeio]

For whatever reason, I can't seem to find the "Sign in with GitHub" from GitLens.

If it's the authentication URL, you should be able to modify it manually:

see #1883 (comment)

Let me know if that works!

[Nick-Hopps]

Here is the entrance:

I've tried that approach, but it results in Bad Request.

[Nick-Hopps]

For the origin URL:

When adding my subpath "/code-server/" to the host name:

Since the page shows the expected result(however nothing happened to code-server), so I think maybe fix the request URL may help.

[jsjoeio]

Thanks for the screenshots!

So I clicked on that, it asked for a PAT, I copied one from https://github.com/settings/tokens and it worked? Can you try that approach instead of the auth URL callback?

[Nick-Hopps]

Wow, it works for me! Thx very much. If only callback also works, it'd be perfect.

[jsjoeio]

I'll let @code-asher chime in and see if he is able to reproduce the issue with the callback

[Nick-Hopps]

waiting for good news 😄

[code-asher]

Ah yup there is a bug where the redirect URL does not include the sub-path. It should be a simple fix but I have not had the chance to look into it.

[jsjoeio]

No worries! I've changed the title to reflect so and added to On Deck. @Nick-Hopps can't tell you when we'll get to it, but it's on the list and will be in an upcoming milestone in the future!

[Nick-Hopps]

No worries! I've changed the title to reflect so and added to On Deck. @Nick-Hopps can't tell you when we'll get to it, but it's on the list and will be in an upcoming milestone in the future!

It's ok and thx again.

[gmrukwa]

Thanks for the screenshots!

So I clicked on that, it asked for a PAT, I copied one from https://github.com/settings/tokens and it worked? Can you try that approach instead of the auth URL callback?

I am using such an approach, but it asks me for the token each time I do git pull or anything else that requires authentication. It just drives me crazy. The answer I suggested here and the solution from that thread don't work anymore. Is there any better solution?

I do have a reverse proxy, too. I replace the corresponding part of the URL, but it doesn't help, exactly like in the case of @Nick-Hopps.

[jsjoeio]

I am using such an approach, but it asks me for the token each time I do git pull or anything else that requires authentication.

Usually when this happens, I think it means git isn't caching your credentials. Have you tried this?

[gmrukwa]

I am using such an approach, but it asks me for the token each time I do git pull or anything else that requires authentication.

Usually when this happens, I think it means git isn't caching your credentials. Have you tried this?

Thanks, it worked. My bad, didn't check this, just thought it's an issue with the code-server. 🤦🏻

[jsjoeio]

My bad, didn't check this, just thought it's an issue with the code-server. 🤦🏻

Happens to all of us once in a while! Glad that's resolved :)

[twittyc]

Hello, If I can be pointed in the right direction. I don't mind doing the work to fix this bug since it affects me. I'm not sure where the callback is in the code.

[jsjoeio]

This is our GitHub auth patch so that's where the code for this should be. That would be a good place to start

[code-asher]

I think I might have fixed this (I must have forgotten this issue existed). Is is still present in latest code-server?

[twittyc]

I cannot complete the OAuth flow for Gitlens+ login (required for their subscription). So I believe so.

[code-asher]

Ahhh my bad I was thinking about the builtin git extension.

It looks like GitLens uses asExternalUri to generate the redirect URI:
https://github.com/gitkraken/vscode-gitlens/blob/ec6e207eae89c87152cff89d70f415cc82602527/src/plus/subscription/serverConnection.ts#L113-L120

So I bet we need to patch asExternalUri to include the full path rather than just the host.

[code-asher]

Is this still a problem in latest code-server? I thought I fixed this but I might be mistaken. https://github.com/coder/code-server/blob/c35bf1311e85d031e40ca42fe0342a47c2c254a8/patches/base-path.diff#L293

[code-asher]

Nearly six months for this comment that I initially sent through email to arrive. How strange. 😛

[Msadat97]

Is there a fix for this? When I use GitLense Sign-in, it redirects me to the GitLense page, but from there, I cannot authorize anything for the code-server. It always opens the local vscode.

The sign-in option in the code-server opens this page instead of the authorization page.

[jsjoeio]

@Msadat97 what version of code-server are you using? and can you provide repro steps? i can look into it

[Msadat97]

I am using the latest version (4.9.0) of code-server. To reproduce this, you can go to the sidebar page of the GitLens extension and click on the sign-in option.

Then, it doesn't redirect to the correct page.

[jsjoeio]

Are there any logs in the browser console? And what page does it redirect to?

[Msadat97]

It basically does nothing other than opening the page that I sent before:

These are the logs that I get, which I think are not relevant.

DevTools failed to load source map: Could not load content for chrome-extension://bmnlcjabgnpnenekpadlanbbkooimhnj/browser-polyfill.js.map: System error: net::ERR_BLOCKED_BY_CLIENT
DevTools failed to load source map: Could not load content for chrome-extension://nllcnknpjnininklegdoijpljgdjkijc/bundles/content.js.map: System error: net::ERR_BLOCKED_BY_CLIENT
DevTools failed to load source map: Could not load content for chrome-extension://nllcnknpjnininklegdoijpljgdjkijc/bundles/writingMonitor.js.map: System error: net::ERR_BLOCKED_BY_CLIENT
DevTools failed to load source map: Could not load content for chrome-extension://nllcnknpjnininklegdoijpljgdjkijc/bundles/content.js.map: System error: net::ERR_BLOCKED_BY_CLIENT
DevTools failed to load source map: Could not load content for chrome-extension://nllcnknpjnininklegdoijpljgdjkijc/bundles/writingMonitor.js.map: System error: net::ERR_BLOCKED_BY_CLIENT
DevTools failed to load source map: Could not load content for chrome-extension://nllcnknpjnininklegdoijpljgdjkijc/bundles/content.js.map: System error: net::ERR_BLOCKED_BY_CLIENT
DevTools failed to load source map: Could not load content for chrome-extension://nllcnknpjnininklegdoijpljgdjkijc/bundles/writingMonitor.js.map: System error: net::ERR_BLOCKED_BY_CLIENT

[jsjoeio]

I can't find the authorization URL it's looking for either.

Screen.Recording.2022-12-12.at.8.56.43.AM.mov

Can you try raising an issue with GitLens? Seems like it's not giving us the authorization URL to paste into code-server.

[Msadat97]

Sure. I will mention the issue with the GitLens team.

[amirhmoradi]

Here is the solution to connect your GitLens Pro account in hosted code-server:
1: Click on the signing link as shown in the screenshot:

2: Allow the usage of GitLens+:

3: "Copy" the link:

4: From the link, extract the gkstate value:
example: b4bbb363-b3e5-4014-efb8-a7a0f9e42135

5: Replace GKSTATE_HERE in the link below with your own gkstate:
⚠️ Careful not to touch the D before, nor the % after the gkstate.

https://app.gitkraken.com/register?referrer=gitlens&pass-token=true&return-url=vscode%3A%2F%2Feamodio.gitlens%2Fdid-authenticate%3Fgkstate%253DGKSTATE_HERE%2526windowId%253D2

6: Open the new URL from step 5 in your browser (not in code-server) and connect to your GitLens Pro account, then the page would redirect to a validation page where you must copy the Authorization URL (do not click on Open in VSCode, if the popup is presented to you as this will open the local vscode and not your hosted Code-Server)

7: Paste the Authorization URL in the popup in Code-Server:

8: Voila: