Sign in not possible in a self hosted VsCode for web

[laupas]

Description

Hi all

I run VsCode (latest docker version from lscr.io/linuxserver/code-server:latest) and have installed Gitlab+ as an extension.
When I try to log in, the redirect is not working.

I tried to get the return URL from the browser URL:
https://app.gitkraken.com/register?referrer=gitlens&pass-token=true&return-url=https://vscode.lauener.zone/stable-XXXXXXXX/callback?vscode-reqid%3D2%26vscode-scheme%3Dcode-oss%26vscode-authority%3Deamodio.gitlens%26vscode-path%3D%252Fdid-authenticate%26vscode-query%3Dgkstate%XXXXXXXXXX

and enter the full URL and just the return_url path in the text box which was showing up on VsCode web to login. But it is not working.

I tried it locally with the following Docker command:

docker run --rm -it
--name=code-server
-e TZ=Europe/London
-p 8443:8443
-v /Users/pascal/work/vscode:/config
lscr.io/linuxserver/code-server:latest

Same error. But what I saw on the output window is:

[2022-11-23 13:00:32.825]
Cancelled
[2022-11-23 13:01:04.071]
Cancelled
[2022-11-23 13:01:42.702]
Cancelled
[2022-11-23 13:01:55.546]
Cancelled
[2022-11-23 13:02:04.799]
Cancelled

same also if I install it locally with brew on mac os

GitLens Version

13

VS Code Version

lscr.io/linuxserver/code-server:latest

Git Version

git version 2.34.1

Logs, Screenshots, Screen Captures, etc

[2022-11-23 13:00:32.825]
Cancelled
[2022-11-23 13:01:04.071]
Cancelled
[2022-11-23 13:01:42.702]
Cancelled
[2022-11-23 13:01:55.546]
Cancelled
[2022-11-23 13:02:04.799]
Cancelled

[tdegrunt]

I'm having the same issue, though I'm using Blink shell and vscode from a VPS, but same thing - can't login to Gitlens +
Is there some way to activate it using a code?

[chof64]

I'm having the same issue, I'm self-hosting VS Code Server.

[sam-ulrich1]

Is there any roadmap to this being resolved? I just bought gitlens only to realize I can't use it

[sam-ulrich1]

@eamodio

[eamodio]

@sam-ulrich1 @chof64 @tdegrunt @laupas

Can you all provide more details on your setup to help us get to the bottom of this? I've tried setting up WSL, Remote Tunnels, VS Code Server, VS Code Remote Tunnels on the web, etc and I don't have any issue logging in to GL+.

[laupas]

Hi @eamodio

I use coder hosted in docker on a mac mini, url exposed with cloudflare tunnel.
Coder version: coder/coder@3ff2ae1
Coder is configured with wildcard access URL and open id authentification.

[sam-ulrich1]

Have you tried the above docker? You can also install the environment with the install script @ https://github.com/coder/code-server

[laupas]

I was initially using VsCode standalone (lscr.io/linuxserver/code-server:latest). Then I tried the Image from https://github.com/coder/code-server, and finally, I moved to a coder Installation. On Coder I use the Image from codercom/code-server:ubuntu as the basis for my VsCode.

I had the same behavior with all 3 installation ways: When I click the "Sign in" button, it redirects me to the gitkraken account page, asks me for login and after several URL forwards, it ends me on the page "https://app.gitkraken.com/products?referrer=gitlens&pass-token=true".

[sam-ulrich1]

I was initially using VsCode standalone (lscr.io/linuxserver/code-server:latest). Then I tried the Image from https://github.com/coder/code-server, and finally, I moved to a coder Installation. On Coder I use the Image from codercom/code-server:ubuntu as the basis for my VsCode.

I had the same behavior with all 3 installation ways: When I click the "Sign in" button, it redirects me to the gitkraken account page, asks me for login and after several URL forwards, it ends me on the page "https://app.gitkraken.com/products?referrer=gitlens&pass-token=true".

@laupas I was responding to @eamodio. With that said, we have the same problem. I've tried code-server on my local machine and on coder including with a public domain and ssl

[sam-ulrich1]

@eamodio Steps to reproduce

1. docker run --rm -it --name=code-server -e TZ=Europe/London -p 8443:8443 lscr.io/linuxserver/code-server:latest
2. Open http://localhost:8443 in your browser
3. Ctrl+~ (Open Terminal)
4. git init
5. Install Gitlens Extension
6. Attempt to sign-in

[sam-ulrich1]

@eamodio just give me a high level description of where to look in the codebase for the pro auth stuff and I'll fix it when I get some free timw

[sam-ulrich1]

@eamodio I paid for GitLens and still can't use it. I'm literally offering to fix this for you if you just meet me half way and give me a high level overview.

[eamodio]

@sam-ulrich1 Sorry for the delay, I've been out for the last 2 weeks. I'm quite sure the issue is on our server-side (we don't allow redirects to a URL we don't "know") and can't be fixed purely from the GitLens side. I am working on other auth changes and will be digging into this at the same time. I'm hopeful we will have a solution in the very near future. Really sorry for the inconvenience.

[eamodio]

@sam-ulrich1 Thank you for the SUPER easy reproduction steps -- I was able to confirm that this must be addressed on our servers and there isn't anything GitLens can do until that happens. The crux of the issue is that we don't want to allow random redirects from our auth for security, but still need to support these dynamic environments. Right now, when we encounter an "unknown" redirect the whole flow is aborted, but we will be adding an alternate flow that won't redirect but will provide a code on the completion page that can be copy/pasted into GitLens that will allow it to complete the auth process.

Again very sorry for the delay and inconvenience here.

[laupas]

@eamodio why you do not add the option, that trusted custom domains can be added on the user account? Or as a simple solution, show the verification code on your site, which can be entered in gitlens (the option to enter is already there).

[eamodio]

@laupas

show the verification code on your site

That's exactly what we are doing

[molamooo]

Here is a temporary fix: coder/code-server#4107