Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extension compatible with current version '1.31.0' of VS Code is not found. #43

Closed
aiyolo opened this issue Mar 6, 2019 · 12 comments
Closed
Assignees
Labels
bug Something isn't working

Comments

@aiyolo
Copy link

aiyolo commented Mar 6, 2019

  • code-server version: 1.31.0
  • OS Version: ubuntu 16.04
  • Extension: settings-sync, chinese-language-pack

Steps to Reproduce

  1. install settings-sync
  2. errors like
    Unable to install because, the extension 'shan.code-settings-sync' compatible with current version '1.31.0' of VS Code is not found.
@nol166
Copy link
Contributor

nol166 commented Mar 6, 2019

@foresthoffman

@kylecarbs
Copy link
Member

Thanks for the report, we'll fix this asap!

@foresthoffman foresthoffman self-assigned this Mar 6, 2019
@foresthoffman
Copy link
Contributor

Ah, it appears that settings-sync has a rather aggressive version constraint: ^1.31.1. We're currently providing 1.31.0, so that explains why it would be failing to install. I've made sure that our version of settings-sync is up to date, so when we update vscode to fulfill that constraint, this should be solved.

@aiyolo
Copy link
Author

aiyolo commented Mar 6, 2019

@foresthoffman thank you

Sent from my MI 8 using FastHub-Libre

@kylecarbs
Copy link
Member

kylecarbs commented Mar 6, 2019

#45 should fix this

@sujunmin
Copy link

sujunmin commented Mar 8, 2019

I think #45 can not fix this, because I just pull latest docker and it says

Unable to install because, the extension 'ms-ceintl.vscode-language-pack-zh-hant' compatible with current version '1.31.1' of VS Code is not found.

So it seems this extensions will check vscode version by using someway.

@nhooyr nhooyr added the bug Something isn't working label Mar 8, 2019
@sujunmin
Copy link

I've pull down the newst docker image from docker hub, and there is no error for installing chinese language package, and it also shows the need to restart vscode to apply, but when I restart it will be at disable extension list, so I can not apply this extension.

@foresthoffman
Copy link
Contributor

The most recent versions of the Chinese language pack are even more strict (than Settings Sync) with the version of VS Code that they require. Version 1.32.4 appears to require at least VS Code 1.32.0.

I believe this will be resolved when we update code-server to 1.32.x.

@sujunmin
Copy link

The most recent versions of the Chinese language pack are even more strict (than Settings Sync) with the version of VS Code that they require. Version 1.32.4 appears to require at least VS Code 1.32.0.

I believe this will be resolved when we update code-server to 1.32.x.

Yes, I test from the docker build locally from the latest source code, and install successfully, the extension is displayed at enable list, but the UI still is in English, the extension description show it need to modify locale.json to fit this extension, but I can not modify it by the instruction.

Once installed, set "locale": "zh-tw" in locale.json to load Chinese (Traditional) Language Pack. To modify locale.json press Ctrl+Shift+P to bring up the Command Palette, start typing "config" to filter the list of available commands, then select the Configure Language command. See Docs for more information.

Maybe this issue is another issue, not the version issue.

@foresthoffman
Copy link
Contributor

Interesting. Are you getting permission errors when attempting to modify the locale.json file?

@sujunmin
Copy link

Finally I found how to change by inputing "display" in command palette or edit locale.json directly from console, the results are the same, nothing happened, like #215 comment.

@kylecarbs
Copy link
Member

Should be fixed. Locale issue can continue in #215

code-asher pushed a commit that referenced this issue Jun 19, 2019
* Add docs

* Add guides for hosting

* Inital commit. Add quick start guide for self hosted

* Add info for flags

* Detail usage flags and provide examples

* Correct file types for certificate

* Add self-signed certificate guide, update .gitignore

* Add additional information.:

* Checkout to master

* Add transition document, add some links to readme

* Comment out some stuff

* Revise transition document

* Fix typo

* Add Google Cloud setup guide

* fix link

* Add guide links to readme

* Add AWS deployment guide

* Fixup based on PR suggestions

* Fixup ssl guide and readme

* Fix typo

* Add step to make binary executable

* Add digitalocean guide, update readme, add chmod steps just in case

* add information about securing the connection to each deploy guide

* Update doc/security/ssl.md

Co-Authored-By: nol166 <jmccamb@gmail.com>

* Fixup from PR suggestions

* Add guide for systemd for when ssh closes

* Fix typos

* VS Code Remote -> code-server

* Fix minor stylistics

* Update readme (#43)

* Update readme

* Add details about chrome warning

* Add back extension ID settings

* Add back SSL guide to readme

* State that chmod is likely not necessary

* Fix type

* Update readme

* Remove transition guide

* Revise readme based on suggestions. (#45)

* Update references to vscode-remote

* No Windows support yet
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

6 participants