Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: autoDetectColorScheme not being respected #6713

Closed
2 of 6 tasks
jasonbentrup opened this issue Mar 7, 2024 · 2 comments
Closed
2 of 6 tasks

[Bug]: autoDetectColorScheme not being respected #6713

jasonbentrup opened this issue Mar 7, 2024 · 2 comments
Labels
bug Something isn't working upstream:vscode Needs to be fixed upstream in VSCode

Comments

@jasonbentrup
Copy link

Is there an existing issue for this?

  • I have searched the existing issues

OS/Web Information

  • Web Browser: Chrome
  • Local OS: Mac OS 14.3.1
  • Remote OS: Ubuntu 22.01
  • Remote Architecture: AWS m5a.large
  • code-server --version: 4.18.0 +

Steps to Reproduce

  1. Install code-server 4.18.0 or higher
  2. Configure your user settings field with the following:
    { "editor.stopRenderingLineAfter" : -1, "window.autoDetectColorScheme": true, "security.workspace.trust.enabled": false, "security.workspace.trust.startupPrompt": "never", "security.workspace.trust.untrustedFiles": "open", "update.mode": "none", "telemetry.telemetryLevel": "off", "workbench.statusBar.visible": false, "workbench.editorLargeFileConfirmation": 35, "workbench.editor.restoreViewState": false }
  3. Set your OS to dark mode
  4. Start code-server

Expected

Code-server will load in dark mode

Actual

Code-server will load in dark mode, then after 2-5 seconds it will switch to light mode. Going into your OS settings and switching to light mode will do nothing (as code server is already in light mode), but then switching to dark mode will get code-server to switch to dark mode.

Logs

No response

Screenshot/Video

code-server-theme.mp4

Does this issue happen in VS Code or GitHub Codespaces?

  • I tested this in native VS Code.
  • This does not happen in native VS Code.
  • I tested this in GitHub Codespaces.
  • This does not happen in GitHub Codespaces.

Are you accessing code-server over a secure context?

  • I am using a secure context.

Notes

We do have a few extensions, so I had tested removing all of those extensions first.

@jasonbentrup jasonbentrup added bug Something isn't working triage This issue needs to be triaged by a maintainer labels Mar 7, 2024
@code-asher
Copy link
Member

I think this is an upstream issue, even in Codespaces it seems to ignore the window.autoDetectColorScheme value and always choose whatever theme is the default.

Looks like there have been a few issues reported upstream already: https://github.com/search?q=repo%3Amicrosoft%2Fvscode+auto+detect+theme&type=issues

@code-asher
Copy link
Member

Closing as an upstream issue.

@code-asher code-asher closed this as not planned Won't fix, can't repro, duplicate, stale Jul 12, 2024
@code-asher code-asher added upstream:vscode Needs to be fixed upstream in VSCode and removed triage This issue needs to be triaged by a maintainer labels Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working upstream:vscode Needs to be fixed upstream in VSCode
Projects
None yet
Development

No branches or pull requests

2 participants