Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Language Pack not work #800

Closed
godla opened this issue Jun 22, 2019 · 10 comments · Fixed by #857
Closed

Language Pack not work #800

godla opened this issue Jun 22, 2019 · 10 comments · Fixed by #857

Comments

@godla
Copy link

godla commented Jun 22, 2019

  • code-server version: code-server1.1156-vsc1.33.1
  • OS Version: centos7
  • Extension: Name: Chinese (Simplified) Language Pack for Visual Studio Co
    Id: ms-ceintl.vscode-language-pack-zh-hans
    Description: Language pack extension for Chinese (Simplified)
    Version: 1.32.4
    Publisher: MS-CEINTL

Description

it is not work

Steps to Reproduce

@deansheather
Copy link
Member

Duplicate of #215

@foxsir
Copy link

foxsir commented Jul 7, 2019

@godla

官方有一个修复语言的分支,现在删除了,我当时clone了,在此基础上初步能用了,还在整理

image

image

@jeasonstudio
Copy link
Contributor

@foxsir PR please.

@foxsir
Copy link

foxsir commented Jul 7, 2019

稍晚些

@xuze1993
Copy link

xuze1993 commented Jul 9, 2019

@godla

官方有一个修复语言的分支,现在删除了,我当时clone了,在此基础上初步能用了,还在整理

image

image

Hi,请问我用commit f123eeb707ddbf3de43c14730cfd49faa1e11c7d这个版本编译为什么会报错呢


图片

@foxsir
Copy link

foxsir commented Jul 9, 2019

@xuze1993

image

模块没找到?,你看有这个文件吗,我修改的不规范,现在没法提交,还修改一点点 vs code 代码,还有问题没弄明白,现在没法 PR

@xuze1993
Copy link

@xuze1993

image

模块没找到?,你看有这个文件吗,我修改的不规范,现在没法提交,还修改一点点 vs code 代码,还有问题没弄明白,现在没法 PR

额 用ad83cad6c9218f8d8d57441e7446701904ba7fa2这个commit编译成功了 不过好像中文还是不行

@foxsir
Copy link

foxsir commented Jul 10, 2019 via email

@foxsir
Copy link

foxsir commented Aug 7, 2019

@xuze1993 @jeasonstudio

我现在已经修复了语言包的支持,但是无法提交上去

我现在的情况是只要fork这个仓库,然后clone到本地,哪怕修改reademe.md 一个字,push上去 再clone下来就编译不通过了,也无报错,你们试过这个流程吗,fork -> 修改提交 -> push -> clone

@foxsir
Copy link

foxsir commented Aug 7, 2019

正常的应该 packages/vscode/out 这个目录编译会出现
image

现在只有一个文件了,无发正常启动了,只是修改reademe.md 都不行

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants