Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cli: add --home flag to customize "Go Home" button #2435

Merged
merged 11 commits into from
Dec 15, 2020
Merged

cli: add --home flag to customize "Go Home" button #2435

merged 11 commits into from
Dec 15, 2020

Conversation

jsjoeio
Copy link
Contributor

@jsjoeio jsjoeio commented Dec 9, 2020 •
edited
Loading

This PR introduces a new cli flag --home which allows the user to customize the "Go Home" button seen in the application menu.

Changes

  • adds the "Go Home" button back to the menu (previously removed in vscode patch to prevent confusion: 5a38ab9)
  • adds --home as a valid CLI flag to configure link for "Go Home" button

Screenshots

2020-12-09 16 18 47

Checklist

  • tested locally in development mode
  • updated the docs
  • updated a test

Related

Fixes #2328

@jsjoeio jsjoeio self-assigned this Dec 9, 2020
@jsjoeio jsjoeio added the enhancement Some improvement that isn't a feature label Dec 9, 2020
@jsjoeio jsjoeio linked an issue Dec 9, 2020 that may be closed by this pull request
Allow customizing Go Home button #2328
Closed
@jsjoeio jsjoeio marked this pull request as ready for review December 10, 2020 18:35
nhooyr
nhooyr reviewed Dec 14, 2020
View reviewed changes
Copy link
Contributor

@nhooyr nhooyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It appears my commit 5a38ab9 was a lie and never actually disabled the home button?

Would be good to revert that in this PR then.

ci/dev/vscode.patch Outdated Show resolved Hide resolved
doc/FAQ.md Show resolved Hide resolved
@nhooyr
Copy link
Contributor

nhooyr commented Dec 14, 2020

Commit separation is really on point @jsjoeio

@jsjoeio
Copy link
Contributor Author

jsjoeio commented Dec 14, 2020

@nhooyr

it appears my commit 5a38ab9 was a lie and never actually disabled the home button?
Would be good to revert that in this PR then.

No, it did disable the home button. I uncommented them but I'm having a hard time finding it in the commits. I can double-check, but I'm sure it's been reverted.

@jsjoeio
Copy link
Contributor Author

jsjoeio commented Dec 14, 2020

If you go here, you can see where your changes (@nhooyr) were reverted: 0e7f504#diff-9e295724ddcc33de1e1e16290c98d43f43e5ce542612dd015d982853be82493cL3869-L3872

@jsjoeio jsjoeio requested a review from nhooyr December 14, 2020 21:37
@jsjoeio
Copy link
Contributor Author

jsjoeio commented Dec 14, 2020

Documenting: @nhooyr hopped on a Zoom call with me. For whatever reason, it worked when he did it and pushed his commit 🤷‍♂️

nhooyr
nhooyr approved these changes Dec 14, 2020
View reviewed changes
Copy link
Contributor

@nhooyr nhooyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@jsjoeio jsjoeio force-pushed the issue-2328-customize-go-home branch 5 times, most recently from f8c00e9 to f941bec Compare December 14, 2020 23:21
@jsjoeio
Copy link
Contributor Author

jsjoeio commented Dec 14, 2020

For anyone who comes here later, the reason I had to force-push was because I had to create a GPG key to sign and verify my commits. The only way to sign old commits was to rebase and force-push.

@jsjoeio jsjoeio merged commit cc584f8 into master Dec 15, 2020
@jsjoeio jsjoeio deleted the issue-2328-customize-go-home branch December 15, 2020 16:52
@jsjoeio jsjoeio mentioned this pull request Dec 15, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nhooyr nhooyr nhooyr approved these changes

@code-asher code-asher code-asher left review comments

Assignees

@jsjoeio jsjoeio

Labels
enhancement Some improvement that isn't a feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow customizing Go Home button
3 participants
@jsjoeio @nhooyr @code-asher