Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update FAQ with extension gallery info #2672

Merged
merged 2 commits into from Feb 10, 2021
Merged

Conversation

oxy
Copy link

@oxy oxy commented Feb 4, 2021

First pass on updating docs to indicate switch to Open-VSX.
Depends on #2659.

I'd appreciate any feedback!

@oxy oxy requested a review from jsjoeio February 4, 2021 21:10
Copy link
Contributor

@jsjoeio jsjoeio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, looks great! A few minor changes

docs/FAQ.md Outdated Show resolved Hide resolved
docs/FAQ.md Outdated Show resolved Hide resolved
docs/FAQ.md Outdated Show resolved Hide resolved
@jsjoeio
Copy link
Contributor

jsjoeio commented Feb 4, 2021

If this depends on #2659, you could update the base branch to that branch? Then if this gets merged, it won't end up on master before that one.

@oxy oxy changed the base branch from master to openvsx-switch February 5, 2021 04:23
@oxy oxy force-pushed the openvsx-switch branch 2 times, most recently from 9974bec to aa59bc4 Compare February 5, 2021 05:59
@jsjoeio jsjoeio modified the milestones: v3.8.1, v3.8.2 Feb 5, 2021
@oxy oxy requested a review from jsjoeio February 8, 2021 20:10
Copy link
Contributor

@jsjoeio jsjoeio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! @oxy 👍🏼

@oxy oxy merged commit d809bf2 into openvsx-switch Feb 10, 2021
@oxy oxy deleted the gallery-docs branch February 10, 2021 19:39
GirlBossRush pushed a commit that referenced this pull request Nov 10, 2021
* docs: update FAQ with extension gallery info (#2672)

* Update app to reflect Open VSX switch.

- Remove extension related github configs.
- Update tests to reflect new upstream behavior.

Co-authored-by: Akash Satheesan <akash@coder.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants