Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename references of "coder cloud" #2906

Merged
merged 1 commit into from
Mar 17, 2021
Merged

Conversation

bpmct
Copy link
Member

@bpmct bpmct commented Mar 17, 2021

Corresponds with coder/cloud-agent#12

@bpmct bpmct requested review from jsjoeio and sreya March 17, 2021 03:00
@bpmct bpmct requested a review from a team as a code owner March 17, 2021 03:00
@jawnsy
Copy link
Contributor

jawnsy commented Mar 17, 2021

Unrelated to your change, but under Hiring there's a link to a job posting which is still visible, but not shown on the main listing page, so I'm not sure if it was taken down - in any case I'd suggest linking to the main page rather than a specific posting, and making the language more generic (something like "Coder is hiring! See our jobs page") so that it's not referring to a specific position, as the open positions change over time

Maybe @cami333 has thoughts here

@cami333
Copy link

cami333 commented Mar 17, 2021

Unrelated to your change, but under Hiring there's a link to a job posting which is still visible, but not shown on the main listing page, so I'm not sure if it was taken down - in any case I'd suggest linking to the main page rather than a specific posting, and making the language more generic (something like "Coder is hiring! See our jobs page") so that it's not referring to a specific position, as the open positions change over time

Maybe @cami333 has thoughts here

@jawnsy I would prefer to just put the careers page link as you suggested. :)

@jsjoeio jsjoeio added this to 🚧 In progress in Clean Up via automation Mar 17, 2021
@jsjoeio jsjoeio added this to the v3.9.2 milestone Mar 17, 2021
Copy link
Contributor

@jsjoeio jsjoeio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Re: Jonathan's change. I'll open a separate PR for that.

@jsjoeio jsjoeio added the merge when passing Merge the PR automatically once all status checks have passed label Mar 17, 2021
@repo-ranger repo-ranger bot merged commit 45a1713 into coder:main Mar 17, 2021
Clean Up automation moved this from 🚧 In progress to ✅ Done Mar 17, 2021
@jsjoeio jsjoeio added merge when passing Merge the PR automatically once all status checks have passed and removed merge when passing Merge the PR automatically once all status checks have passed labels Mar 17, 2021
@jsjoeio jsjoeio changed the title rename references of "coder could" rename references of "coder cloud" Mar 23, 2021
@jsjoeio jsjoeio added the chore Related to maintenance or clean up label May 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Related to maintenance or clean up
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants