Make sure directories exist #3309

code-asher · 2021-05-07T16:36:21Z

Now that we are creating the directories these shouldn't error. If they are somehow missing (if the user deletes them after VS Code starts for example) then I think we should surface that to the user.

codecov · 2021-05-07T17:35:08Z

Codecov Report

Merging #3309 (51d294e) into main (b21a9af) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #3309   +/-   ##
=======================================
  Coverage   58.95%   58.95%           
=======================================
  Files          35       35           
  Lines        1703     1703           
  Branches      374      374           
=======================================
  Hits         1004     1004           
  Misses        561      561           
  Partials      138      138

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b21a9af...51d294e. Read the comment docs.

jsjoeio

Woo! Really happy we're getting this fix in 👏

code-asher requested a review from a team as a code owner May 7, 2021 16:36

code-asher force-pushed the create-dirs branch from 8188556 to d99267a Compare May 7, 2021 16:40

code-asher added 2 commits May 7, 2021 12:31

Make sure directories exist

9ff29d1

Fixes coder#3040.

Remove extension dir scan catch

51d294e

Now that we are creating the directories these shouldn't error. If they are somehow missing (if the user deletes them after VS Code starts for example) then I think we should surface that to the user.

code-asher force-pushed the create-dirs branch from e731f43 to 51d294e Compare May 7, 2021 17:31

jsjoeio added this to the v3.9.4 milestone May 7, 2021

jsjoeio added the enhancement Some improvement that isn't a feature label May 7, 2021

jsjoeio assigned code-asher May 7, 2021

jsjoeio approved these changes May 7, 2021

View reviewed changes

code-asher merged commit 99317fc into coder:main May 7, 2021

code-asher deleted the create-dirs branch May 7, 2021 18:29

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Make sure directories exist #3309

Make sure directories exist #3309

code-asher commented May 7, 2021

codecov bot commented May 7, 2021

jsjoeio left a comment

Make sure directories exist #3309

Make sure directories exist #3309

Conversation

code-asher commented May 7, 2021

codecov bot commented May 7, 2021

Codecov Report

jsjoeio left a comment

Choose a reason for hiding this comment