docs(contributing): add commits section #3377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsjoeio
force-pushed
the
jsjoeio/docs-clean-commits
branch
from
071adbb
to
cf5efbb
Compare
jawnsy
reviewed
May 12, 2021
Codecov Report
@@ Coverage Diff @@
## main #3377 +/- ##
=======================================
Coverage 59.21% 59.21%
=======================================
Files 35 35
Lines 1709 1709
Branches 379 379
=======================================
Hits 1012 1012
Misses 559 559
Partials 138 138 Continue to review full report at Codecov.
|
code-asher
reviewed
May 14, 2021
docs/CONTRIBUTING.md
Outdated
|
|
||
| ### Commits | ||
|
|
||
| We prefer a clean commit history. This means you should squash all commits before asking for review (cleanup, squash, force-push). If you need help with this, feel free to leave a comment in your PR and we'll guide you. |
There was a problem hiding this comment.
squash all commits == PRs should only have one commit? Or does that just mean to squash fixups and fixup-type commits?
There was a problem hiding this comment.
Squash fixups and fixup-type commits - let me reword to clarify! Good point.
jsjoeio
force-pushed
the
jsjoeio/docs-clean-commits
branch
from
ece723c
to
0209e9f
Compare
code-asher
approved these changes
May 14, 2021
jsjoeio
force-pushed
the
jsjoeio/docs-clean-commits
branch
from
0209e9f
to
60d71fe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds some note to
CONTRIBUTING.mdaround clean commits.Checklist
CHANGELOG.md