Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(maintaining): add merge strategies section #3379

Merged
merged 1 commit into from
May 12, 2021

Conversation

jsjoeio
Copy link
Contributor

@jsjoeio jsjoeio commented May 12, 2021

This PR updates MAINTAINING.md with "Merge Strategies" providing some recommendations.

Checklist

  • updated CHANGELOG.md

@jsjoeio jsjoeio added this to the v3.11.0 milestone May 12, 2021
@jsjoeio jsjoeio added the docs Documentation related label May 12, 2021
@jsjoeio jsjoeio self-assigned this May 12, 2021
@jsjoeio jsjoeio force-pushed the jsjoeio/docs-merge-strategy branch from 5660dba to 7a8701b Compare May 12, 2021 22:49
@jsjoeio jsjoeio changed the base branch from main to jsjoeio/milestones-issues May 12, 2021 22:50
@codecov
Copy link

codecov bot commented May 12, 2021

Codecov Report

Merging #3379 (7a8701b) into jsjoeio/milestones-issues (5469e61) will not change coverage.
The diff coverage is n/a.

❗ Current head 7a8701b differs from pull request most recent head b5c9ae8. Consider uploading reports for the commit b5c9ae8 to get more accurate results
Impacted file tree graph

@@                    Coverage Diff                     @@
##           jsjoeio/milestones-issues    #3379   +/-   ##
==========================================================
  Coverage                      58.95%   58.95%           
==========================================================
  Files                             35       35           
  Lines                           1703     1703           
  Branches                         374      374           
==========================================================
  Hits                            1004     1004           
  Misses                           561      561           
  Partials                         138      138           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5469e61...b5c9ae8. Read the comment docs.

@jsjoeio jsjoeio force-pushed the jsjoeio/docs-merge-strategy branch from 7a8701b to b5c9ae8 Compare May 12, 2021 22:53
@jsjoeio jsjoeio marked this pull request as ready for review May 12, 2021 22:53
@jsjoeio jsjoeio requested a review from a team as a code owner May 12, 2021 22:53
@@ -69,6 +69,7 @@ VS Code v1.56

- docs(install): add raspberry pi section #3376 @jsjoeio
- docs(maintaining): add pull requests section #3378 @jsjoeio
- docs(maintaining): add merge strategies section #3379 @jsjoeio
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

while you're here, can you also fix my changelog entry below? 🙏 I forgot the PR number and author info 😳

@jsjoeio jsjoeio merged commit 6cadbc4 into jsjoeio/milestones-issues May 12, 2021
@jsjoeio jsjoeio deleted the jsjoeio/docs-merge-strategy branch May 12, 2021 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants