Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: clean up test file structure #3866

Merged
merged 1 commit into from
Jul 29, 2021
Merged

Conversation

jsjoeio
Copy link
Contributor

@jsjoeio jsjoeio commented Jul 27, 2021

This PR cleans up the test file structure to match /src.

@jsjoeio jsjoeio requested a review from a team as a code owner July 27, 2021 23:53
@jsjoeio jsjoeio added the chore Related to maintenance or clean up label Jul 27, 2021
@jsjoeio jsjoeio self-assigned this Jul 27, 2021
@jsjoeio jsjoeio added this to the 3.12.0 milestone Jul 27, 2021
@jsjoeio jsjoeio changed the title refactor: match /test/unit structure to /src refactor: clean up test file structure Jul 27, 2021
@jsjoeio jsjoeio added the testing Anything related to testing label Jul 27, 2021
@jsjoeio
Copy link
Contributor Author

jsjoeio commented Jul 28, 2021

Now this is confusing. Everything passes locally. I am not sure why the unit tests are failing in CI 🤔

@code-asher helped me figure it out. Forgot to update the typings alias in the tsconfig.json in the test plugin.

@codecov
Copy link

codecov bot commented Jul 28, 2021

Codecov Report

Merging #3866 (807e475) into main (7a5c457) will not change coverage.
The diff coverage is n/a.

❗ Current head 807e475 differs from pull request most recent head 7a6ec20. Consider uploading reports for the commit 7a6ec20 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3866   +/-   ##
=======================================
  Coverage   63.40%   63.40%           
=======================================
  Files          36       36           
  Lines        1872     1872           
  Branches      379      379           
=======================================
  Hits         1187     1187           
  Misses        582      582           
  Partials      103      103           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a5c457...7a6ec20. Read the comment docs.

Copy link

@oxy oxy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks neat! 🚀 for organization

@jsjoeio jsjoeio merged commit 7e43f7d into main Jul 29, 2021
@jsjoeio jsjoeio deleted the jsjoeio-reorg-test-files branch July 29, 2021 22:14
@jsjoeio jsjoeio modified the milestones: 3.12.0, 3.11.1 Aug 6, 2021
@ahmadyahya11 ahmadyahya11 mentioned this pull request Aug 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Related to maintenance or clean up testing Anything related to testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants