Fix no-auth disabling https #573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nol166
changed the title
code-asher
approved these changes
Apr 23, 2019
kylejeske
added a commit
to 2n2b1/code-server
that referenced
this pull request
Apr 24, 2019
* Add --socket flag (coder#564) * Add --socket flag * Add msg for already bound socket * Bundle grammars (coder#563) * Fix clipboard pasting * Remove log statement from copy * Offer https/http url based on schema (coder#572) * Let people know when telemetry is disabled, change url to https if secure connection * Remove --no-auth as a http candidate * Rename variable, change let to const * Fix no-auth to still use HTTPS, set default for no-auth to false (coder#573) * Fix markdown preview focus (coder#546) * Fix hash * Remove whitespace
|
Either this issue still exists or it hasn't made it into the docker version as of yet |
nwtnsqrd
reviewed
May 24, 2019
| @@ -133,7 +133,7 @@ export const createApp = async (options: CreateAppOptions): Promise<{ | |||
| }); | |||
| }); | |||
|
|
|||
| const server = httpolyglot.createServer(options.bypassAuth ? {} : options.httpsOptions || certs, app) as http.Server; | |||
| const server = httpolyglot.createServer(options.allowHttp ? {} : options.httpsOptions || certs, app) as http.Server; | |||
There was a problem hiding this comment.
This change causes (SSL: error:14094410:SSL routines:ssl3_read_bytes:sslv3 alert handshake failure:SSL alert number 40) when running code-server behind a reverse proxy which provides SSL. Although this is likely due to faulty configuration of the reverse proxy. In nginx, I had to change
location / {
proxy_pass https://localhost:8443;
[...]
to
location / {
proxy_pass http://localhost:8443;
[...]
Just posting this here in case anyone mis-configured their reverse proxy like I did ;)
code-asher
pushed a commit
that referenced
this pull request
Jun 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe in detail the problem you had and how this PR fixes it
--no-authdisallows password requirement and SSL, it should instead only disallow the password requirement. Changes the default value from undefined to false for the--no-authflagIs there an open issue you can link to?
fixes #300