Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release: 4.9.0 #5772

Merged
merged 25 commits into from
Dec 6, 2022
Merged

release: 4.9.0 #5772

merged 25 commits into from
Dec 6, 2022

Conversation

jsjoeio
Copy link
Contributor

@jsjoeio jsjoeio commented Nov 10, 2022

Published as a release candidate which can be installed via:

curl -fsSL https://code-server.dev/install.sh | sh -s -- --edge --standalone

@jsjoeio jsjoeio self-assigned this Nov 10, 2022
@jsjoeio jsjoeio changed the title wip: changelog release: 4.9.0 Nov 10, 2022
@jsjoeio jsjoeio temporarily deployed to npm November 10, 2022 18:42 Inactive
@jsjoeio jsjoeio temporarily deployed to npm November 10, 2022 18:44 Inactive
@github-actions
Copy link

github-actions bot commented Nov 10, 2022

✨ code-server dev build published to npm for PR #5772!

  • Last publish status: success
  • Commit: 99033dd

To install in a local project, run:

npm install @coder/code-server-pr@5772

To install globally, run:

npm install -g @coder/code-server-pr@5772

@codecov
Copy link

codecov bot commented Nov 10, 2022

Codecov Report

Merging #5772 (99033dd) into main (df49838) will increase coverage by 2.27%.
The diff coverage is 40.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5772      +/-   ##
==========================================
+ Coverage   72.66%   74.94%   +2.27%     
==========================================
  Files          30       30              
  Lines        1683     1688       +5     
  Branches      370      371       +1     
==========================================
+ Hits         1223     1265      +42     
+ Misses        397      361      -36     
+ Partials       63       62       -1     
Impacted Files Coverage Δ
src/node/routes/index.ts 78.64% <25.00%> (-2.17%) ⬇️
src/node/wrapper.ts 25.62% <100.00%> (+25.62%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f43082e...99033dd. Read the comment docs.

@jsjoeio jsjoeio temporarily deployed to npm November 10, 2022 18:54 Inactive
@jsjoeio jsjoeio temporarily deployed to npm November 10, 2022 20:01 Inactive
@jsjoeio jsjoeio temporarily deployed to npm November 10, 2022 20:25 Inactive
@jsjoeio jsjoeio temporarily deployed to npm November 10, 2022 20:51 Inactive
@jsjoeio jsjoeio temporarily deployed to npm November 30, 2022 19:38 Inactive
@jsjoeio
Copy link
Contributor Author

jsjoeio commented Nov 30, 2022

Terminal is not working as shared first here: #5769 (comment)

Need to fix this before releasing.

@jsjoeio
Copy link
Contributor Author

jsjoeio commented Nov 30, 2022

Oddly enough...when I run yarn watch locally, the terminal is working 🤔

image

I'm going to test installing this via npm locally next.

@jsjoeio
Copy link
Contributor Author

jsjoeio commented Nov 30, 2022

Works on npm too 🤔

image

Maybe it's only affecting the non-npm builds? I'll try creating a standalone release locally.

@jsjoeio
Copy link
Contributor Author

jsjoeio commented Nov 30, 2022

How I'm testing standalone release:

  1. download npm artifact into code-server repo locally (on main branch) from here
  2. unzip
  3. run yarn release:standalone
  4. run node ./release-standalone --port 3000

Still same result 🤔
image

Last thing I'll do is try running the yarn package step and testing the macOS package to see if that has any differences.

@jsjoeio
Copy link
Contributor Author

jsjoeio commented Nov 30, 2022

Tested with yarn package like so:

  1. VERSION="4.9.0-joe" yarn package
  2. tar -xzf ./release-packages/code-server-4.9.0-joe-macos-amd64.tar.gz
  3. node ./code-server-4.9.0-joe-macos-amd64 --port 3000

And still no issues 🤔
image

Only other thing that comes to mind is creating a draft release which will build artifacts in CI, then I can download them and test those (in case something in CI is being funky).

@jsjoeio
Copy link
Contributor Author

jsjoeio commented Nov 30, 2022

@jsjoeio
Copy link
Contributor Author

jsjoeio commented Nov 30, 2022

Used the macos build from CI uploaded to draft release and still no issues 🤔

image

The last thing I can try is using a Linux build. I'll try that and report back.

@jsjoeio
Copy link
Contributor Author

jsjoeio commented Nov 30, 2022

Hmm...I couldn't run code-server from in a Coder OSS workspace 🤔 I'm not sure why:
image

I think the next best option is to publish a release candidate 2 and have others test.

While testing a pre-release, there seems to be a bug with the file
permissions for `product.json`. Adding `chmod +x` to see if that fixes
it.
@jsjoeio jsjoeio temporarily deployed to npm December 1, 2022 17:30 Inactive
@jsjoeio jsjoeio temporarily deployed to npm December 1, 2022 17:44 Inactive
@jsjoeio jsjoeio temporarily deployed to npm December 1, 2022 18:10 Inactive
@jsjoeio jsjoeio temporarily deployed to npm December 2, 2022 21:07 Inactive
@jsjoeio
Copy link
Contributor Author

jsjoeio commented Dec 2, 2022

see adobe/fetch#318 (comment)

@jsjoeio jsjoeio temporarily deployed to npm December 2, 2022 22:23 Inactive
@jsjoeio jsjoeio temporarily deployed to npm December 2, 2022 22:36 Inactive
@jsjoeio jsjoeio marked this pull request as ready for review December 5, 2022 22:41
@jsjoeio jsjoeio requested a review from a team as a code owner December 5, 2022 22:41
@jsjoeio
Copy link
Contributor Author

jsjoeio commented Dec 5, 2022

Release candidates have been tested and I've tested locally so I'm confident we can release this now. cc @code-asher

@jsjoeio jsjoeio temporarily deployed to npm December 5, 2022 22:45 Inactive
@@ -0,0 +1,18 @@
import { ChildProcess } from "child_process"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated to release. Added to keep code coverage from decreasing and CI ✅

@jsjoeio jsjoeio temporarily deployed to npm December 5, 2022 23:13 Inactive
@jsjoeio jsjoeio temporarily deployed to npm December 6, 2022 15:58 Inactive
@jsjoeio jsjoeio temporarily deployed to npm December 6, 2022 16:05 Inactive
Copy link
Member

@code-asher code-asher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after we export ChildProcess.

CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: Asher <ash@coder.com>
@jsjoeio jsjoeio added the rebase when passing Rebase and merge the PR automatically once all status checks have passed label Dec 6, 2022
@jsjoeio jsjoeio temporarily deployed to npm December 6, 2022 18:32 Inactive
@jsjoeio jsjoeio merged commit 1484bee into main Dec 6, 2022
@jsjoeio jsjoeio deleted the release/v4.9.0 branch December 6, 2022 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rebase when passing Rebase and merge the PR automatically once all status checks have passed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants