Skip to content
This repository has been archived by the owner on Aug 30, 2024. It is now read-only.

Integration tests shouldn't require bind mounts #128

Closed
deansheather opened this issue Sep 22, 2020 · 5 comments
Closed

Integration tests shouldn't require bind mounts #128

deansheather opened this issue Sep 22, 2020 · 5 comments
Assignees

Comments

@deansheather
Copy link
Member

Bind mounts don't work within Coder enterprise because Docker runs in a different container to the main environment container, so it's impossible to run integration tests while dogfooding.

@deansheather
Copy link
Member Author

This would be accomplishable by spawning a dud container that did nothing with a persistent volume attached, copying the files in with docker cp and then reusing that volume for all commands.

@cmoog
Copy link
Contributor

cmoog commented Sep 22, 2020

The only reason we have bind mounts in tcli is to inject the CLI binary at startup. So we can definitely accomplish that in a more compatible way.

@cmoog cmoog self-assigned this Sep 22, 2020
@deansheather
Copy link
Member Author

Another solution @cmoog would be to keep the binary in the home directory, as the home directory is mounted into sidecar containers.

@cmoog
Copy link
Contributor

cmoog commented Sep 23, 2020

I don't think it makes sense to optimize our integration tests for the docker-in-docker case given that these will usually be running in an external CI pipeline. My latest attempt at fixing this also seems to be falling (#130) so I'm tempted to close this issue. Any objections @deansheather ?

@deansheather
Copy link
Member Author

Not a big deal I guess, just means I'll have to run this locally

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants