-
Notifications
You must be signed in to change notification settings - Fork 18
Integration tests shouldn't require bind mounts #128
Comments
This would be accomplishable by spawning a dud container that did nothing with a persistent volume attached, copying the files in with |
The only reason we have bind mounts in |
Another solution @cmoog would be to keep the binary in the home directory, as the home directory is mounted into sidecar containers. |
I don't think it makes sense to optimize our integration tests for the docker-in-docker case given that these will usually be running in an external CI pipeline. My latest attempt at fixing this also seems to be falling (#130) so I'm tempted to close this issue. Any objections @deansheather ? |
Not a big deal I guess, just means I'll have to run this locally |
Bind mounts don't work within Coder enterprise because Docker runs in a different container to the main environment container, so it's impossible to run integration tests while dogfooding.
The text was updated successfully, but these errors were encountered: