chore: add e2e for user login/logout flow #13185
Conversation
|
@BrunoQuaresma Do you happen to know why an e2e test would succeed locally, but not remotely, especially if it doesn't have anything to do with enterprise features? |
|
Taking this out of review for the moment – I think I've realized what the problem is (not enough test isolation), and I'm going to tinker with this a bit more |
| orgId: string, | ||
| username: string = randomName(), | ||
| password: string = "s3cure&password!", | ||
| ) => { |
There was a problem hiding this comment.
nit: instead of having the user params passed as an argument what about creating a param type that could merge/override the default values?
| * JS-based runtime for the test environments to the Go-based runtime for the | ||
| * production backend. | ||
| */ | ||
| export async function assertNoUncaughtRenderError(page: Page): Promise<void> { |
There was a problem hiding this comment.
nit: maybe this function could have a more friendly name like assertNoUnexpectedUIError. I think the word Uncaught is not very common at least for me.
| await setupNewUser(); | ||
|
|
||
| await handleSignIn(); | ||
| await handleSignOut(); |
There was a problem hiding this comment.
Why the sign-in and sign-out tests are encapsulated into functions? I would expect each one to be a separate test.
| @@ -19,6 +20,8 @@ export interface UserDropdownProps { | |||
| onSignOut: () => void; | |||
| } | |||
|
|
|||
| export const accessibleDropdownLabel = "Open dropdown menu for user options"; | |||
There was a problem hiding this comment.
off: I'm always wondering how long labels should be. Imagining myself using an interface via audio... long texts could slow me down. Just a random thought.
Fully closes #13130 by filling in the gaps that #13137 and #13145 can't cover
Changes made
getByRoleselectorsNotes