Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use FALLBACK_IMAGE when no devcontainer specified #17

Open
bpmct opened this issue Jun 28, 2023 · 5 comments
Open

use FALLBACK_IMAGE when no devcontainer specified #17

bpmct opened this issue Jun 28, 2023 · 5 comments
Labels
enhancement New feature or request

Comments

@bpmct
Copy link
Member

bpmct commented Jun 28, 2023

We currently have FALLBACK_IMAGE. If an devcontainer is not specified, we should also support a KITCHENSINK_IMAGE (or use the fallback image for this too). Then, an admin can maintain an image that works in "most" cases.

@matifali matifali added the enhancement New feature or request label Jan 30, 2024
@michaelbrewer
Copy link
Contributor

I do like this as a generic option to support "Open in Coder" for all projects and would enable a browser extension for Coder (see coder/coder#8589)

@bpmct bpmct added this to the envbuilder v1.0 milestone Apr 10, 2024
@bpmct
Copy link
Member Author

bpmct commented Apr 10, 2024

We have several customers heavily using the kitchensink image approach, I think we should invest in this so that an envbuilder template can be a generic template.

Open question: is fallback image good enough, or is there a rationale to have both?

@michaelbrewer
Copy link
Contributor

Fall back would suite my needs. I still need to see if I can get private nexus authentication to work.

@johnstcn
Copy link
Member

Given: a user runs envbuilder with the following:

  • Git repo that does not contain a devcontainer spec
  • FALLBACK_IMAGE=some_image:some_tag

When: envbuilder is run

Then: envbuilder should gracefully continue without a devcontainer and build an environment consisting of FALLBACK_IMAGE.

@johnstcn johnstcn changed the title kitchensink image support use FALLBACK_IMAGE when no devcontainer specified May 20, 2024
@bpmct
Copy link
Member Author

bpmct commented May 20, 2024

Totally makes sense!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants