Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vscode-web): set --host 127.0.0.1 #216

Merged
merged 1 commit into from Apr 5, 2024
Merged

fix(vscode-web): set --host 127.0.0.1 #216

merged 1 commit into from Apr 5, 2024

Conversation

matifali
Copy link
Contributor

@matifali matifali commented Apr 5, 2024

MS code-server defaults to using --host localhost, which worked perfectly with Coder.

But recently Coder is failing to proxy vscode-web with the coder/coder#12790

As a workaround, setting --host 127.0.0.1 works.

Details

ok so Running (the default if we skip --host)
/tmp/vscode-web/bin/code-server serve-local --port 13340 --host localhost --accept-server-license-terms serve-local --without-connection-token --telemetry-level error gives

Server bound to ::1:13338(IPv6)
Extension host agent listening on 13338

But if we set --host 127.0.0.1

Server bound to 127.0.0.1:13338 (IPv4)
Extension host agent listening on 13338

[12:55:24] 

Web UI available at http://localhost:13338/
[12:55:24] Extension host agent started.

This binds to ipv4.
Is this something that changed at Coder or Microsoft?
Because vs code-server was setting --host localhost and did not change any behavior.

MS code-server defaults to using `--host localhost`, which was working perfectly fine with Coder.

But recently Coder is failing to proxy vscode-web with the coder/coder#12790 

As a workaround setting `--host 127.0.0.1` works.
@matifali matifali requested a review from coadler April 5, 2024 13:06
@matifali matifali changed the title fix(vscode-web): use --host 127.0.01 fix(vscode-web): use --host 127.0.0.1 Apr 5, 2024
@matifali matifali changed the title fix(vscode-web): use --host 127.0.0.1 fix(vscode-web): set--host 127.0.0.1 Apr 5, 2024
@coadler coadler changed the title fix(vscode-web): set--host 127.0.0.1 fix(vscode-web): set --host 127.0.0.1 Apr 5, 2024
@matifali matifali merged commit 838ec95 into main Apr 5, 2024
2 checks passed
@matifali matifali deleted the vscode-web-host branch April 10, 2024 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants