-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enble pressing enter key #42
Conversation
…n the login failure view.
@ujhuyz0110 It’s a nice feature but can you please move those bind into _initialize_view method to make its code more clean look? |
@CSaratakij You got it. I've moved them to _initialize_view and deleted the .swp. |
@ujhuyz0110 so close... , that is in init of data not view. |
@CSaratakij Thanks for pointing that out ;) |
@ujhuyz0110 That's a nice feature you added. Any thoughts on adding a splash screen before the app loads? I have a ready-made template that I built like this https://github.com/HarowitzBlack/cool-tkinter-gui-stuff. @CSaratakij any thoughts? EDIT: hey @ujhuyz0110, I just saw the changes you made. The problem is that I've added some UI changes to the app for both formlogin.py and loginfailure.py merging your repo will remove my changes (It hasn't been merged yet). Can you fix that please? |
@HarowitzBlack Do it~ 👍 |
@CSaratakij cool! I'm on it 😁 |
Yes! I will add this to the latest version later today |
Please close #42. I have created another PR to add the functionality to the new interface. |
Used bind method to enable functionalities:
I was thinking to add a functionality pressing enter key to send message too. But in this case, there might be conflict with occasion when users just wanna start a new line in the message. How do you guys feel about it?