avoid relative path in loading codemirror #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coderaiser
pushed a commit
that referenced
this pull request
Jun 15, 2017
…./lib/codemirror -> codemirror/lib/codemirror (#3)
|
Thank you, merged as 5e7a0af |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We found the relative path does not work in some certain scenarios.
For example, when installing using bower inside codemirror, by default it will be installed under codermirror/app/components, which will make the relative path fail.
In addition, in our use case we want to install this addon as another bower components same as codemirror, using relative path prevent us from doing that.
By using absolute path, the user can define where their codemirror is installed and use that to call the requireJS API to configure the path:
requirejs.config({ paths: { codemirror: '../components/codemirror' } });