Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Patch 1 #1

Closed
wants to merge 5 commits into from
Closed

Patch 1 #1

wants to merge 5 commits into from

Conversation

josher19
Copy link
Contributor

@josher19 josher19 commented Dec 12, 2019 •
edited

itype(null) === 'null' but itype.null(null) === false because typeof null === 'object' (don't ask me why).

josher19 and others added 5 commits December 12, 2019 11:30
@josher19
Update itype.js
062742c 
`typeof null === 'object'` not 'null'.
@jweinsteincbt
Update itype.js
a6e7b5b 
Add unit tests, one of which fill fail without patched code.
@josher19
Merge pull request #1 from jweinsteincbt/patch-2
0102ea2 
Update itype.js
@jweinsteincbt
npm build
f855c7c
@josher19
Merge pull request #2 from jweinsteincbt/patch-2
e356482 
npm build
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling e356482 on josher19:patch-1 into 364c811 on coderaiser:master.

coderaiser pushed a commit that referenced this pull request Dec 13, 2019
@josher19 @coderaiser
feature(itype) add suppor of null (#1)
9cb378b
@coderaiser
Copy link
Owner

coderaiser commented Dec 13, 2019 •
edited

Thank :), you merged as 9cb378b, landed in v2.0.4 🎉

@coderaiser coderaiser closed this Dec 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@josher19 @coveralls @coderaiser @jweinsteincbt