Fix exception in user registration form.

The app was doing some basic saving of form submission data before redirecting to the login page. Unfortunately it was a rather naive implementation that didn't work but did introduce a problem with duplicate fields when submitting from the login or registration pages. All that code has been removed because it doesn't work. At some point, it would be good to handle authentication during form submission better so users don't lose their data.
coderberry · Mar 16, 2012 · df72934 · df72934
1 parent feec90d
commit df72934
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 10 deletions.
diff --git a/grails-app/controllers/org/grails/auth/UserController.groovy b/grails-app/controllers/org/grails/auth/UserController.groovy
@@ -97,9 +97,7 @@ class UserController {
     }
 
     def register(){
-        def renderParams = [ model:[originalURI:params.originalURI,
-                      formData:params,
-                      async:request.xhr] ]
+        def renderParams = [ model:[originalURI:params.originalURI, async:request.xhr] ]
 
         if(request.xhr)
             renderParams.template = "registerForm"
@@ -199,7 +197,6 @@ class UserController {
                     params.remove 'password'
                     render(template:"loginForm", model:[originalURI:params.remove('originalURI'),
                                                         update: params._ul,
-                                                        formData:params,
                                                         async:true,
                                                         message:"auth.invalid.login"])
                 } else {

diff --git a/grails-app/views/user/_loginForm.gsp b/grails-app/views/user/_loginForm.gsp
@@ -1,7 +1,7 @@
 <g:setProvider library="yui" />
 
 <g:set var="updateElement" value="${update ?: 'contentPane'}"/>
-<g:set var="paramExclusions" value="['login', 'async', 'Submit']"/>
+<g:set var="paramExclusions" value="['login', 'async', 'Submit', 'controller', 'action']"/>
 
 <g:render template="/common/messages" model="${pageScope.getVariables() + [bean:wikiPage]}" />
 

diff --git a/grails-app/views/user/_registerForm.gsp b/grails-app/views/user/_registerForm.gsp
@@ -28,11 +28,6 @@
 
 
         <g:hiddenField name="originalURI" value="${originalURI}" />
-        <g:each in="${formData?}" var="d">
-            <g:if test="${!['login','password', 'password2', 'originalURI', 'email'].contains(d.key)}">
-                <g:hiddenField name="${d.key}" value="${d.value}" />
-            </g:if>
-        </g:each>
 
        <div class="formButtons" style="margin-top:100px;">
             <g:submitButton name="Submit" value="Register" />