Fix #290: Load doc file with absolute path #291
Merged
+8
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yasulab
changed the title
|
バグは |
path/に移動した際にURLが正常に踏め、遷移先が正常に見えているテストを追加 した
|
@yasulab テストコード追加しました! |
|
@AnaTofuZ 現在の状態がレビュー準備が整った状態なのかどうか分からないので今のところ様子見している状態ですが、準備できたら |
AnaTofuZ
changed the title
|
@yasulab 了解です 🙇 yasulabさんがreviewerにassign出来なかったのでナラさんにリクエストしました |
|
👍 ✨ |
nalabjp
approved these changes
Mar 19, 2018
|
PR & Review ありがとうございます 😆マージしちゃいますね ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #290
cc/ @yu-san-19
やること
とりあえず僕の方でここまでやりました ✅
テストコードの部分、お願いします 🙏 > アナグラさん