New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
連名で登録している道場もカウント可能にする #860
Merged
yasulab
merged 6 commits into
master
from
add-counter-column-to-dojo-for-joint-registration
Jun 21, 2020
Merged
連名で登録している道場もカウント可能にする #860
yasulab
merged 6 commits into
master
from
add-counter-column-to-dojo-for-joint-registration
Jun 21, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yasulab
added
急ぎじゃないよ
Make something better but not rushed.
統計情報
Tracking event record function via APIs: https://coderdojo.jp/stats
labels
Jun 21, 2020
chicaco
reviewed
Jun 21, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
counter 方式、シンプルでよさそうですね。
(自分は上位クラスを作るアプローチを考えていましたが、ぱっとは整理できなかったので)
WIP なので一旦コメントに留めておきますが、問題ないと思います!
早速のレビューありがとうございます!(>人< )💖 |
こちら CI も通ったのでマージしますね! 🚀🆕✨ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #610
連名で登録している道場もカウントできるようにしました! d( ̄  ̄)✨
@chicaco デザインの部分以外はできたので (デザイン部分もデザイン案は既に上がっていてあとは実装するだけなので)、一旦レビューお願いできると嬉しいです...!! (>人< )✨
やること
counter
カラムの追加 (Default: 1, null: false) 91e4da3counter
カラムを使って集計するように改善 6015c5dcounter
カラムに関するドキュメントを追加 0e59e22counter
カラムの数をトップページに反映する (デザイン改善)やらないこと
パッと見てどう対応するとベターなのか思いつかったので、Issue として切り出して一旦後回しにしました >< 💦 (Issue: #862 )
当該コード部には TODO コメントを追記 📝