New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CSVの書き込みの手前でおちる #34

Closed

miya0001 opened this issue Jul 26, 2017 · 1 comment

Labels

バグ

Member

miya0001 commented Jul 26, 2017

以下のところでたまに落ちる。たぶんAPIのタイムアウト。
https://travis-ci.org/coderdojo-japan/dojopaas#L480

エラーが一回出ただけで停止しないようにして、何回かリトライさせて一定時間経過後に解消しなければエラーを履いて停止させるって感じかな。

Member Author

miya0001 commented Jul 26, 2017

あっ、この行がおかしい。
send() の中の resolve() の手前に入れないと通ってない。
https://github.com/coderdojo-japan/dojopaas/blob/master/lib/Server.js#L162

miya0001 added the バグ label

miya0001 mentioned this issue

Merged

miya0001 closed this as completed in

ce0ac57

miya0001 added a commit that referenced this issue


          Merge pull request #35 from coderdojo-japan/bug-fix

8e3dc48

fixed #34

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment