#5584: Faces remove their windings from the render buffers when the o…

…wning brush goes invisible

radiantcore/brush/BrushNode.cpp

@@ -664,3 +664,14 @@ void BrushNode::_applyTransformation()
 
     _untransformedOriginChanged = true;
 }
+
+void BrushNode::onVisibilityChanged(bool isVisibleNow)
+{
+    SelectableNode::onVisibilityChanged(isVisibleNow);
+
+    // Let each face know about the change
+    forEachFaceInstance([=](FaceInstance& face)
+    {
+        face.getFace().onBrushVisibilityChanged(isVisibleNow);
+    });
+}

radiantcore/brush/BrushNode.h

@@ -177,6 +177,8 @@ class BrushNode :
     void onPostRedo() override;
 
 protected:
+    virtual void onVisibilityChanged(bool isVisibleNow) override;
+
     virtual void setForcedVisibility(bool forceVisible, bool includeChildren) override;
 
 	// Gets called by the Transformable implementation whenever

radiantcore/brush/Face.cpp

@@ -730,6 +730,20 @@ bool Face::isVisible() const
     return _faceIsVisible;
 }
 
+void Face::onBrushVisibilityChanged(bool visible)
+{
+    if (!visible)
+    {
+        // Disconnect our renderable when the owning brush goes invisible
+        _windingSurface.clear();
+    }
+    else
+    {
+        // Update the vertex buffers next we need to render
+        _windingSurface.queueUpdate();
+    }
+}
+
 void Face::updateFaceVisibility()
 {
     auto newValue = contributes() && getFaceShader().getGLShader()->getMaterial()->isVisible();

radiantcore/brush/Face.h

@@ -212,6 +212,9 @@ class Face :
 
 	bool isVisible() const override;
 
+    // Called when the owning brush changes its visibility status
+    void onBrushVisibilityChanged(bool visible);
+
 	void updateFaceVisibility();
 
 	// Signal for external code to get notified each time the texdef of any face changes