Skip to content

Commit

Permalink
Simplify VC++ property setup. Move /EHsc switch to base property shee…
Browse files Browse the repository at this point in the history
…t, enable conformant mode /permissive- although add the switch /Zc:twoPhase- in order to fix compiler error C2760 in combaseapi.h:229
  • Loading branch information
codereader committed Dec 19, 2017
1 parent 86e9702 commit 2ea6454
Show file tree
Hide file tree
Showing 32 changed files with 70 additions and 228 deletions.
8 changes: 4 additions & 4 deletions tools/msvc/DarkRadiant.vcxproj
Expand Up @@ -111,7 +111,7 @@
</PropertyGroup>
<ItemDefinitionGroup Condition="'$(Configuration)|$(Platform)'=='Debug|Win32'">
<ClCompile>
<AdditionalOptions>/EHsc /Zm200 %(AdditionalOptions)</AdditionalOptions>
<AdditionalOptions>/Zm200 %(AdditionalOptions)</AdditionalOptions>
<Optimization>Disabled</Optimization>
<AdditionalIncludeDirectories>$(SolutionDir)/../../radiant;%(AdditionalIncludeDirectories)</AdditionalIncludeDirectories>
<PreprocessorDefinitions>_CRT_SECURE_NO_DEPRECATE;WIN32;_DEBUG;_CONSOLE;%(PreprocessorDefinitions)</PreprocessorDefinitions>
Expand Down Expand Up @@ -167,7 +167,7 @@
<TargetEnvironment>X64</TargetEnvironment>
</Midl>
<ClCompile>
<AdditionalOptions>/EHsc /Zm200 %(AdditionalOptions)</AdditionalOptions>
<AdditionalOptions>/Zm200 %(AdditionalOptions)</AdditionalOptions>
<Optimization>Disabled</Optimization>
<AdditionalIncludeDirectories>$(SolutionDir)/../../radiant;%(AdditionalIncludeDirectories)</AdditionalIncludeDirectories>
<PreprocessorDefinitions>_CRT_SECURE_NO_DEPRECATE;WIN32;_DEBUG;_CONSOLE;%(PreprocessorDefinitions)</PreprocessorDefinitions>
Expand Down Expand Up @@ -219,7 +219,7 @@
</ItemDefinitionGroup>
<ItemDefinitionGroup Condition="'$(Configuration)|$(Platform)'=='Release|Win32'">
<ClCompile>
<AdditionalOptions>/EHsc /Zm200 %(AdditionalOptions)</AdditionalOptions>
<AdditionalOptions>/Zm200 %(AdditionalOptions)</AdditionalOptions>
<InlineFunctionExpansion>AnySuitable</InlineFunctionExpansion>
<IntrinsicFunctions>true</IntrinsicFunctions>
<FavorSizeOrSpeed>Speed</FavorSizeOrSpeed>
Expand Down Expand Up @@ -274,7 +274,7 @@
<TargetEnvironment>X64</TargetEnvironment>
</Midl>
<ClCompile>
<AdditionalOptions>/EHsc /Zm200 %(AdditionalOptions)</AdditionalOptions>
<AdditionalOptions>/Zm200 %(AdditionalOptions)</AdditionalOptions>
<InlineFunctionExpansion>AnySuitable</InlineFunctionExpansion>
<IntrinsicFunctions>true</IntrinsicFunctions>
<FavorSizeOrSpeed>Speed</FavorSizeOrSpeed>
Expand Down
8 changes: 0 additions & 8 deletions tools/msvc/archivezip.vcxproj
Expand Up @@ -52,25 +52,21 @@
<ImportGroup Condition="'$(Configuration)|$(Platform)'=='Release|Win32'" Label="PropertySheets">
<Import Project="$(UserRootDir)\Microsoft.Cpp.$(Platform).user.props" Condition="exists('$(UserRootDir)\Microsoft.Cpp.$(Platform).user.props')" Label="LocalAppDataPlatform" />
<Import Project="properties\DarkRadiant Base Release Win32.props" />

<Import Project="properties\zlib.props" />
</ImportGroup>
<ImportGroup Condition="'$(Configuration)|$(Platform)'=='Debug|Win32'" Label="PropertySheets">
<Import Project="$(UserRootDir)\Microsoft.Cpp.$(Platform).user.props" Condition="exists('$(UserRootDir)\Microsoft.Cpp.$(Platform).user.props')" Label="LocalAppDataPlatform" />
<Import Project="properties\DarkRadiant Base Debug Win32.props" />

<Import Project="properties\zlib.props" />
</ImportGroup>
<ImportGroup Condition="'$(Configuration)|$(Platform)'=='Release|x64'" Label="PropertySheets">
<Import Project="$(UserRootDir)\Microsoft.Cpp.$(Platform).user.props" Condition="exists('$(UserRootDir)\Microsoft.Cpp.$(Platform).user.props')" Label="LocalAppDataPlatform" />
<Import Project="properties\DarkRadiant Base Release x64.props" />

<Import Project="properties\zlib.props" />
</ImportGroup>
<ImportGroup Condition="'$(Configuration)|$(Platform)'=='Debug|x64'" Label="PropertySheets">
<Import Project="$(UserRootDir)\Microsoft.Cpp.$(Platform).user.props" Condition="exists('$(UserRootDir)\Microsoft.Cpp.$(Platform).user.props')" Label="LocalAppDataPlatform" />
<Import Project="properties\DarkRadiant Base Debug x64.props" />

<Import Project="properties\zlib.props" />
</ImportGroup>
<PropertyGroup Label="UserMacros" />
Expand Down Expand Up @@ -109,7 +105,6 @@
</Command>
</CustomBuildStep>
<ClCompile>
<AdditionalOptions>/EHsc</AdditionalOptions>
<Optimization>Disabled</Optimization>
<PreprocessorDefinitions>_CRT_SECURE_NO_DEPRECATE;WIN32;%(PreprocessorDefinitions)</PreprocessorDefinitions>
<StringPooling>true</StringPooling>
Expand Down Expand Up @@ -161,7 +156,6 @@
<TargetEnvironment>X64</TargetEnvironment>
</Midl>
<ClCompile>
<AdditionalOptions>/EHsc</AdditionalOptions>
<Optimization>Disabled</Optimization>
<PreprocessorDefinitions>_CRT_SECURE_NO_DEPRECATE;WIN32;%(PreprocessorDefinitions)</PreprocessorDefinitions>
<StringPooling>true</StringPooling>
Expand Down Expand Up @@ -209,7 +203,6 @@
</Command>
</CustomBuildStep>
<ClCompile>
<AdditionalOptions>/EHsc</AdditionalOptions>
<InlineFunctionExpansion>AnySuitable</InlineFunctionExpansion>
<IntrinsicFunctions>true</IntrinsicFunctions>
<FavorSizeOrSpeed>Speed</FavorSizeOrSpeed>
Expand Down Expand Up @@ -263,7 +256,6 @@
<TargetEnvironment>X64</TargetEnvironment>
</Midl>
<ClCompile>
<AdditionalOptions>/EHsc</AdditionalOptions>
<InlineFunctionExpansion>AnySuitable</InlineFunctionExpansion>
<IntrinsicFunctions>true</IntrinsicFunctions>
<FavorSizeOrSpeed>Speed</FavorSizeOrSpeed>
Expand Down
8 changes: 0 additions & 8 deletions tools/msvc/commandsystem.vcxproj
Expand Up @@ -52,25 +52,21 @@
<ImportGroup Condition="'$(Configuration)|$(Platform)'=='Release|Win32'" Label="PropertySheets">
<Import Project="$(UserRootDir)\Microsoft.Cpp.$(Platform).user.props" Condition="exists('$(UserRootDir)\Microsoft.Cpp.$(Platform).user.props')" Label="LocalAppDataPlatform" />
<Import Project="properties\DarkRadiant Base Release Win32.props" />

<Import Project="properties\libxml2.props" />
</ImportGroup>
<ImportGroup Condition="'$(Configuration)|$(Platform)'=='Debug|Win32'" Label="PropertySheets">
<Import Project="$(UserRootDir)\Microsoft.Cpp.$(Platform).user.props" Condition="exists('$(UserRootDir)\Microsoft.Cpp.$(Platform).user.props')" Label="LocalAppDataPlatform" />
<Import Project="properties\DarkRadiant Base Debug Win32.props" />

<Import Project="properties\libxml2.props" />
</ImportGroup>
<ImportGroup Condition="'$(Configuration)|$(Platform)'=='Release|x64'" Label="PropertySheets">
<Import Project="$(UserRootDir)\Microsoft.Cpp.$(Platform).user.props" Condition="exists('$(UserRootDir)\Microsoft.Cpp.$(Platform).user.props')" Label="LocalAppDataPlatform" />
<Import Project="properties\DarkRadiant Base Release x64.props" />

<Import Project="properties\libxml2.props" />
</ImportGroup>
<ImportGroup Condition="'$(Configuration)|$(Platform)'=='Debug|x64'" Label="PropertySheets">
<Import Project="$(UserRootDir)\Microsoft.Cpp.$(Platform).user.props" Condition="exists('$(UserRootDir)\Microsoft.Cpp.$(Platform).user.props')" Label="LocalAppDataPlatform" />
<Import Project="properties\DarkRadiant Base Debug x64.props" />

<Import Project="properties\libxml2.props" />
</ImportGroup>
<PropertyGroup Label="UserMacros" />
Expand Down Expand Up @@ -109,7 +105,6 @@
</Command>
</CustomBuildStep>
<ClCompile>
<AdditionalOptions>/EHsc</AdditionalOptions>
<Optimization>Disabled</Optimization>
<PreprocessorDefinitions>_CRT_SECURE_NO_DEPRECATE;WIN32;%(PreprocessorDefinitions)</PreprocessorDefinitions>
<StringPooling>true</StringPooling>
Expand Down Expand Up @@ -162,7 +157,6 @@
<TargetEnvironment>X64</TargetEnvironment>
</Midl>
<ClCompile>
<AdditionalOptions>/EHsc</AdditionalOptions>
<Optimization>Disabled</Optimization>
<PreprocessorDefinitions>_CRT_SECURE_NO_DEPRECATE;WIN32;%(PreprocessorDefinitions)</PreprocessorDefinitions>
<StringPooling>true</StringPooling>
Expand Down Expand Up @@ -211,7 +205,6 @@
</Command>
</CustomBuildStep>
<ClCompile>
<AdditionalOptions>/EHsc</AdditionalOptions>
<InlineFunctionExpansion>AnySuitable</InlineFunctionExpansion>
<IntrinsicFunctions>true</IntrinsicFunctions>
<FavorSizeOrSpeed>Speed</FavorSizeOrSpeed>
Expand Down Expand Up @@ -266,7 +259,6 @@
<TargetEnvironment>X64</TargetEnvironment>
</Midl>
<ClCompile>
<AdditionalOptions>/EHsc</AdditionalOptions>
<InlineFunctionExpansion>AnySuitable</InlineFunctionExpansion>
<IntrinsicFunctions>true</IntrinsicFunctions>
<FavorSizeOrSpeed>Speed</FavorSizeOrSpeed>
Expand Down
12 changes: 4 additions & 8 deletions tools/msvc/dm.conversation.vcxproj
Expand Up @@ -52,31 +52,27 @@
<ImportGroup Condition="'$(Configuration)|$(Platform)'=='Release|Win32'" Label="PropertySheets">
<Import Project="$(UserRootDir)\Microsoft.Cpp.$(Platform).user.props" Condition="exists('$(UserRootDir)\Microsoft.Cpp.$(Platform).user.props')" Label="LocalAppDataPlatform" />
<Import Project="properties\DarkRadiant Base Release Win32.props" />

<Import Project="properties\libxml2.props" />
<Import Project="properties\GLEW.props" />
<Import Project="properties\wxWidgets.props" />
</ImportGroup>
<ImportGroup Condition="'$(Configuration)|$(Platform)'=='Debug|Win32'" Label="PropertySheets">
<Import Project="$(UserRootDir)\Microsoft.Cpp.$(Platform).user.props" Condition="exists('$(UserRootDir)\Microsoft.Cpp.$(Platform).user.props')" Label="LocalAppDataPlatform" />
<Import Project="properties\DarkRadiant Base Debug Win32.props" />

<Import Project="properties\libxml2.props" />
<Import Project="properties\GLEW.props" />
<Import Project="properties\wxWidgets.props" />
</ImportGroup>
<ImportGroup Condition="'$(Configuration)|$(Platform)'=='Release|x64'" Label="PropertySheets">
<Import Project="$(UserRootDir)\Microsoft.Cpp.$(Platform).user.props" Condition="exists('$(UserRootDir)\Microsoft.Cpp.$(Platform).user.props')" Label="LocalAppDataPlatform" />
<Import Project="properties\DarkRadiant Base Release x64.props" />

<Import Project="properties\libxml2.props" />
<Import Project="properties\GLEW.props" />
<Import Project="properties\wxWidgets.props" />
</ImportGroup>
<ImportGroup Condition="'$(Configuration)|$(Platform)'=='Debug|x64'" Label="PropertySheets">
<Import Project="$(UserRootDir)\Microsoft.Cpp.$(Platform).user.props" Condition="exists('$(UserRootDir)\Microsoft.Cpp.$(Platform).user.props')" Label="LocalAppDataPlatform" />
<Import Project="properties\DarkRadiant Base Debug x64.props" />

<Import Project="properties\libxml2.props" />
<Import Project="properties\GLEW.props" />
<Import Project="properties\wxWidgets.props" />
Expand Down Expand Up @@ -117,7 +113,7 @@
</Command>
</CustomBuildStep>
<ClCompile>
<AdditionalOptions>/EHsc</AdditionalOptions>
<AdditionalOptions>/Zm200 %(AdditionalOptions)</AdditionalOptions>
<Optimization>Disabled</Optimization>
<PreprocessorDefinitions>_CRT_SECURE_NO_DEPRECATE;WIN32;%(PreprocessorDefinitions)</PreprocessorDefinitions>
<StringPooling>true</StringPooling>
Expand Down Expand Up @@ -170,7 +166,7 @@
<TargetEnvironment>X64</TargetEnvironment>
</Midl>
<ClCompile>
<AdditionalOptions>/EHsc</AdditionalOptions>
<AdditionalOptions>/Zm200 %(AdditionalOptions)</AdditionalOptions>
<Optimization>Disabled</Optimization>
<PreprocessorDefinitions>_CRT_SECURE_NO_DEPRECATE;WIN32;%(PreprocessorDefinitions)</PreprocessorDefinitions>
<StringPooling>true</StringPooling>
Expand Down Expand Up @@ -219,7 +215,7 @@
</Command>
</CustomBuildStep>
<ClCompile>
<AdditionalOptions>/EHsc</AdditionalOptions>
<AdditionalOptions>/Zm200 %(AdditionalOptions)</AdditionalOptions>
<InlineFunctionExpansion>AnySuitable</InlineFunctionExpansion>
<IntrinsicFunctions>true</IntrinsicFunctions>
<FavorSizeOrSpeed>Speed</FavorSizeOrSpeed>
Expand Down Expand Up @@ -274,7 +270,7 @@
<TargetEnvironment>X64</TargetEnvironment>
</Midl>
<ClCompile>
<AdditionalOptions>/EHsc</AdditionalOptions>
<AdditionalOptions>/Zm200 %(AdditionalOptions)</AdditionalOptions>
<InlineFunctionExpansion>AnySuitable</InlineFunctionExpansion>
<IntrinsicFunctions>true</IntrinsicFunctions>
<FavorSizeOrSpeed>Speed</FavorSizeOrSpeed>
Expand Down
8 changes: 4 additions & 4 deletions tools/msvc/dm.difficulty.vcxproj
Expand Up @@ -113,7 +113,7 @@
</Command>
</CustomBuildStep>
<ClCompile>
<AdditionalOptions>/EHsc</AdditionalOptions>
<AdditionalOptions>/Zm200 %(AdditionalOptions)</AdditionalOptions>
<Optimization>Disabled</Optimization>
<PreprocessorDefinitions>_CRT_SECURE_NO_DEPRECATE;WIN32;%(PreprocessorDefinitions)</PreprocessorDefinitions>
<StringPooling>true</StringPooling>
Expand Down Expand Up @@ -167,7 +167,7 @@
<TargetEnvironment>X64</TargetEnvironment>
</Midl>
<ClCompile>
<AdditionalOptions>/EHsc</AdditionalOptions>
<AdditionalOptions>/Zm200 %(AdditionalOptions)</AdditionalOptions>
<Optimization>Disabled</Optimization>
<PreprocessorDefinitions>_CRT_SECURE_NO_DEPRECATE;WIN32;%(PreprocessorDefinitions)</PreprocessorDefinitions>
<StringPooling>true</StringPooling>
Expand Down Expand Up @@ -217,7 +217,7 @@
</Command>
</CustomBuildStep>
<ClCompile>
<AdditionalOptions>/EHsc</AdditionalOptions>
<AdditionalOptions>/Zm200 %(AdditionalOptions)</AdditionalOptions>
<InlineFunctionExpansion>AnySuitable</InlineFunctionExpansion>
<IntrinsicFunctions>true</IntrinsicFunctions>
<FavorSizeOrSpeed>Speed</FavorSizeOrSpeed>
Expand Down Expand Up @@ -272,7 +272,7 @@
<TargetEnvironment>X64</TargetEnvironment>
</Midl>
<ClCompile>
<AdditionalOptions>/EHsc</AdditionalOptions>
<AdditionalOptions>/Zm200 %(AdditionalOptions)</AdditionalOptions>
<InlineFunctionExpansion>AnySuitable</InlineFunctionExpansion>
<IntrinsicFunctions>true</IntrinsicFunctions>
<FavorSizeOrSpeed>Speed</FavorSizeOrSpeed>
Expand Down
8 changes: 4 additions & 4 deletions tools/msvc/dm.editing.vcxproj
Expand Up @@ -109,7 +109,7 @@
</Command>
</CustomBuildStep>
<ClCompile>
<AdditionalOptions>/EHsc</AdditionalOptions>
<AdditionalOptions>/Zm200 %(AdditionalOptions)</AdditionalOptions>
<Optimization>Disabled</Optimization>
<PreprocessorDefinitions>_CRT_SECURE_NO_DEPRECATE;WIN32;%(PreprocessorDefinitions)</PreprocessorDefinitions>
<StringPooling>true</StringPooling>
Expand Down Expand Up @@ -162,7 +162,7 @@
<TargetEnvironment>X64</TargetEnvironment>
</Midl>
<ClCompile>
<AdditionalOptions>/EHsc</AdditionalOptions>
<AdditionalOptions>/Zm200 %(AdditionalOptions)</AdditionalOptions>
<Optimization>Disabled</Optimization>
<PreprocessorDefinitions>_CRT_SECURE_NO_DEPRECATE;WIN32;%(PreprocessorDefinitions)</PreprocessorDefinitions>
<StringPooling>true</StringPooling>
Expand Down Expand Up @@ -211,7 +211,7 @@
</Command>
</CustomBuildStep>
<ClCompile>
<AdditionalOptions>/EHsc</AdditionalOptions>
<AdditionalOptions>/Zm200 %(AdditionalOptions)</AdditionalOptions>
<InlineFunctionExpansion>AnySuitable</InlineFunctionExpansion>
<IntrinsicFunctions>true</IntrinsicFunctions>
<FavorSizeOrSpeed>Speed</FavorSizeOrSpeed>
Expand Down Expand Up @@ -266,7 +266,7 @@
<TargetEnvironment>X64</TargetEnvironment>
</Midl>
<ClCompile>
<AdditionalOptions>/EHsc</AdditionalOptions>
<AdditionalOptions>/Zm200 %(AdditionalOptions)</AdditionalOptions>
<InlineFunctionExpansion>AnySuitable</InlineFunctionExpansion>
<IntrinsicFunctions>true</IntrinsicFunctions>
<FavorSizeOrSpeed>Speed</FavorSizeOrSpeed>
Expand Down
8 changes: 4 additions & 4 deletions tools/msvc/dm.gui.vcxproj
Expand Up @@ -113,7 +113,7 @@
</Command>
</CustomBuildStep>
<ClCompile>
<AdditionalOptions>/EHsc</AdditionalOptions>
<AdditionalOptions>/Zm200 %(AdditionalOptions)</AdditionalOptions>
<Optimization>Disabled</Optimization>
<PreprocessorDefinitions>_CRT_SECURE_NO_DEPRECATE;WIN32;%(PreprocessorDefinitions)</PreprocessorDefinitions>
<StringPooling>true</StringPooling>
Expand Down Expand Up @@ -166,7 +166,7 @@
<TargetEnvironment>X64</TargetEnvironment>
</Midl>
<ClCompile>
<AdditionalOptions>/EHsc</AdditionalOptions>
<AdditionalOptions>/Zm200 %(AdditionalOptions)</AdditionalOptions>
<Optimization>Disabled</Optimization>
<PreprocessorDefinitions>_CRT_SECURE_NO_DEPRECATE;WIN32;%(PreprocessorDefinitions)</PreprocessorDefinitions>
<StringPooling>true</StringPooling>
Expand Down Expand Up @@ -215,7 +215,7 @@
</Command>
</CustomBuildStep>
<ClCompile>
<AdditionalOptions>/EHsc</AdditionalOptions>
<AdditionalOptions>/Zm200 %(AdditionalOptions)</AdditionalOptions>
<InlineFunctionExpansion>AnySuitable</InlineFunctionExpansion>
<IntrinsicFunctions>true</IntrinsicFunctions>
<FavorSizeOrSpeed>Speed</FavorSizeOrSpeed>
Expand Down Expand Up @@ -270,7 +270,7 @@
<TargetEnvironment>X64</TargetEnvironment>
</Midl>
<ClCompile>
<AdditionalOptions>/EHsc</AdditionalOptions>
<AdditionalOptions>/Zm200 %(AdditionalOptions)</AdditionalOptions>
<InlineFunctionExpansion>AnySuitable</InlineFunctionExpansion>
<IntrinsicFunctions>true</IntrinsicFunctions>
<FavorSizeOrSpeed>Speed</FavorSizeOrSpeed>
Expand Down

0 comments on commit 2ea6454

Please sign in to comment.