#5151: Avoid returning a reference to a temporary object

codereader · Apr 11, 2020 · 4304b1f · 4304b1f
1 parent eae81b8
commit 4304b1f
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/radiant/entity/target/TargetLineNode.cpp b/radiant/entity/target/TargetLineNode.cpp
@@ -48,7 +48,7 @@ std::size_t TargetLineNode::getHighlightFlags()
     return Highlight::NoHighlight;
 }
 
-const Vector3& TargetLineNode::getOwnerPosition() const
+Vector3 TargetLineNode::getOwnerPosition() const
 {
     try
     {

diff --git a/radiant/entity/target/TargetLineNode.h b/radiant/entity/target/TargetLineNode.h
@@ -41,7 +41,7 @@ class TargetLineNode :
 	std::size_t getHighlightFlags() override;
 
 private:
-    const Vector3& getOwnerPosition() const;
+    Vector3 getOwnerPosition() const;
 };
 
 }