#5584: Why not letting std::vector use its default growth strategy

codereader · Nov 15, 2021 · 4b4e6b4 · 4b4e6b4
1 parent 1eb8191
commit 4b4e6b4
Showing 1 changed file with 2 additions and 6 deletions.
diff --git a/libs/render/CompactWindingVertexBuffer.h b/libs/render/CompactWindingVertexBuffer.h
@@ -108,16 +108,12 @@ class CompactWindingVertexBuffer
         assert(winding.size() == _size);
 
         const auto currentSize = _vertices.size();
-        auto position = currentSize / _size;
-        _vertices.reserve(currentSize + _size); // reserve() never shrinks
-
+
         std::copy(winding.begin(), winding.end(), std::back_inserter(_vertices));
 
-        // Allocate and calculate indices
-        _indices.reserve(_indices.size() + getNumIndicesPerWinding());
-
         WindingIndexerT::GenerateAndAssignIndices(std::back_inserter(_indices), _size, static_cast<unsigned int>(currentSize));
 
+        auto position = currentSize / _size;
         return static_cast<Slot>(position);
     }