Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix unwanted extra rotations when translating rotated func_static
When Doom3Group and Doom3GroupNode were merged, all of the methods from Doom3Group were moved into Doom3GroupNode. Two of these methods were revertTransform() and freezeTransform(), which had the same name as virtuals on the Transformable interface and therefore became unintentional overrides, obliterating important functionality from Transformable which we still need in Doom3GroupNode. The fact that these methods triggered a "missing override keyword" warning ought to have been an important red flag, but unfortunately I just mechanically added the keyword without considering if these new methods actually *should* have been overriding anything.
- Loading branch information
Matthew Mott
committed
Nov 30, 2021
1 parent
79c1f77
commit 54dc20e
Showing
2 changed files
with
8 additions
and
10 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters