#5231: Fix PatchInspector constantly updating after first update() ca…

…ll due to the _updateNeeded flag not being cleared.
codereader · Jun 28, 2020 · 7782291 · 7782291
1 parent 7efa99a
commit 7782291
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/radiant/ui/patch/PatchInspector.cpp b/radiant/ui/patch/PatchInspector.cpp
@@ -16,6 +16,7 @@
 #include "registry/Widgets.h"
 #include "selectionlib.h"
 #include "wxutil/ControlButton.h"
+#include "util/ScopedBoolLock.h"
 
 #include <functional>
 
@@ -199,7 +200,9 @@ void PatchInspector::queueUpdate()
 
 void PatchInspector::update()
 {
-	_updateActive = true;
+	util::ScopedBoolLock lock(_updateActive);
+
+	_updateNeeded = false;
 
 	auto patch = _patch.lock();
 
@@ -217,8 +220,6 @@ void PatchInspector::update()
 		// Load the data from the currently selected vertex
 		loadControlVertex();
 	}
-
-	_updateActive = false;
 }
 
 void PatchInspector::loadControlVertex()