Consolidate 'Enable/Disable camera sync' commands

Instead of separate commands to enable or disable camera sync with no
indication of the current status, there is now a single toggle option 'Game
position follows DarkRadiant camera'.

Also renamed "Sync camera back now" to "Move camera to current game position",
and added a menu separator underneath these two camera options to separate them
from the following map-related options.

include/iuimanager.h

@@ -67,21 +67,21 @@ class IMenuManager
 	 */
 	virtual void setVisibility(const std::string& path, bool visible) = 0;
 
-	/** greebo: Adds a new item as child under the given path.
-	 *
-	 * @insertPath: the path where to insert the item: "main/filters"
-	 * @name: the name of the new item
-	 * @type: the item type (usually menuFolder / menuItem)
-	 * @caption: the display string of the menu item (incl. mnemonic)
-	 * @icon: the icon filename (can be empty)
-	 * @eventname: the event name (e.g. "ToggleShowSizeInfo")
-	 */
-	virtual void add(const std::string& insertPath,
-						   const std::string& name,
-						   ui::eMenuItemType type,
-						   const std::string& caption,
-						   const std::string& icon,
-						   const std::string& eventName) = 0;
+    /** greebo: Adds a new item as child under the given path.
+     *
+     * @insertPath: the path where to insert the item: "main/filters"
+     * @name: the name of the new item
+     * @type: the item type (usually menuFolder / menuItem)
+     * @caption: the display string of the menu item (incl. mnemonic)
+     * @icon: the icon filename (can be empty)
+     * @eventname: the event name (e.g. "ToggleShowSizeInfo")
+     */
+    virtual void add(const std::string& insertPath,
+                     const std::string& name,
+                     ui::eMenuItemType type,
+                     const std::string& caption = "",
+                     const std::string& icon = "",
+                     const std::string& eventName = "") = 0;
 
 	/** greebo: Inserts a new menuItem as sibling _before_ the given insertPath.
 	 *

plugins/dm.gameconnection/GameConnection.cpp

@@ -213,11 +213,12 @@ const StringSet& GameConnection::getDependencies() const
 
 void GameConnection::initialiseModule(const IApplicationContext& ctx)
 {
+    GlobalEventManager().addToggle(
+        "GameConnectionToggleCameraSync",
+        [this](bool v) { setCameraSyncEnabled(v); }
+    );
+
     // Add commands
-    GlobalCommandSystem().addCommand("GameConnectionCameraSyncEnable",
-        [this](const cmd::ArgumentList&) { setCameraSyncEnabled(true); });
-    GlobalCommandSystem().addCommand("GameConnectionCameraSyncDisable",
-        [this](const cmd::ArgumentList&) { setCameraSyncEnabled(false); });
     GlobalCommandSystem().addCommand("GameConnectionBackSyncCamera",
         [this](const cmd::ArgumentList&) { backSyncCamera(); });
     GlobalCommandSystem().addCommand("GameConnectionReloadMap",
@@ -242,12 +243,13 @@ void GameConnection::initialiseModule(const IApplicationContext& ctx)
     // Add menu items
     IMenuManager& mm = GlobalUIManager().getMenuManager();
     mm.insert("main/help", "connection", ui::menuFolder, _("Connection"), "", "");
+
     mm.add("main/connection", "cameraSyncEnable", ui::menuItem,
-           _("Enable camera synchronization"), "", "GameConnectionCameraSyncEnable");
-    mm.add("main/connection", "cameraSyncDisable", ui::menuItem,
-           _("Disable camera synchronization"), "", "GameConnectionCameraSyncDisable");
+           _("Game position follows DarkRadiant camera"), "", "GameConnectionToggleCameraSync");
     mm.add("main/connection", "backSyncCamera", ui::menuItem,
-           _("Sync camera back now"), "", "GameConnectionBackSyncCamera");
+           _("Move camera to current game position"), "", "GameConnectionBackSyncCamera");
+    mm.add("main/connection", "postCameraSep", ui::menuSeparator);
+
     mm.add("main/connection", "reloadMap", ui::menuItem,
            _("Reload map from .map file"), "", "GameConnectionReloadMap");
     mm.add("main/connection", "reloadMapAutoEnable", ui::menuItem,