Skip to content

Commit

Permalink
#6009: RenderableSurfaces with invisible shaders don't attach themsel…
Browse files Browse the repository at this point in the history
…ves to any shader

This includes the shared wireframe shader that is always visible, surfaces
must be prevented from adding their geometry to any shader.
  • Loading branch information
codereader committed Oct 29, 2022
1 parent 1364228 commit af383b9
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions radiantcore/model/ModelNodeBase.cpp
Expand Up @@ -87,8 +87,9 @@ void ModelNodeBase::attachToShaders()
{
auto shader = renderSystem->capture(surface->getSurface().getActiveMaterial());

// Skip filtered materials
//TODO if (!shader->isVisible()) continue;
// Skip filtered materials - the wireframe shader itself is always visible
// so filtered surfaces need to be kept from attaching their geometry
if (!shader->isVisible()) continue;

// Solid mode
surface->attachToShader(shader);
Expand Down

0 comments on commit af383b9

Please sign in to comment.