#6178: fix potentially uninitialised matrices in XYWnd

This seems to be the last of the Valgrind warnings that appear before the main window is shown, other than those which appear in third-party code (e.g. wxWidgets) and probably aren't fixable on our side.
codereader · Nov 29, 2022 · dc63b7c · dc63b7c
1 parent c8fe8ce
commit dc63b7c
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/radiant/xyview/XYWnd.cpp b/radiant/xyview/XYWnd.cpp
@@ -1,6 +1,7 @@
 #include "XYWnd.h"
 
 #include "i18n.h"
+#include "iclipper.h"
 #include "iscenegraph.h"
 #include "iundo.h"
 #include "ui/imainframe.h"
@@ -36,6 +37,7 @@
 #include <fmt/format.h>
 #include <sigc++/functors/mem_fun.h>
 #include <functional>
+#include <wx/sizer.h>
 
 namespace ui
 {

diff --git a/radiant/xyview/XYWnd.h b/radiant/xyview/XYWnd.h
@@ -93,8 +93,8 @@ class XYWnd final :
     int _chasemouseDeltaX;
     int _chasemouseDeltaY;
 
-    Matrix4 _projection;
-    Matrix4 _modelView;
+    Matrix4 _projection = Matrix4::getIdentity();
+    Matrix4 _modelView = Matrix4::getIdentity();
 
     int _width;
     int _height;