New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid out-of-bound access on corner cases / when readlink fails. #14

Merged

codereader merged 1 commit into codereader:master from coldtobi:fix_getExecutablePath

Jan 19, 2021

coldtobi commented Jan 17, 2021

When looking if I could enable Hurd support (Hurd does not have PATH_MAX), I spotted these two out-of-bound bugs in getExecutablePath()

if readlink fails, (returns -1), but the fallback worked, ret will still be -1, so the code will "Nul-Terminate" at buf[-1] (
readlink might return PATH_MAX. In this case, the nul termination will write buf[PATH_MAX], one byte beyond the array.
For this, it is easiest to just allocate 1 byte more for the array.


          Avoid out-of-bound access on corner cases / when readlink fails.

ba3ac9a

codereader merged commit a0300c9 into codereader:master

Owner

codereader commented Jan 19, 2021

Thanks a lot for the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment