KUBESAW-43: Replace the special ToolchainClusterCondition with the standard toolchain Condition

[fbm3307]

This is to replace the special ToolchainClusterCondition with the standard toolchain Condition

This is Related to Change in

• API - KUBESAW-43: Replace the special ToolchainClusterCondition with the standard toolchain Condition api#416
• Toolchain-Common - KUBESAW-43: Replace the special ToolchainClusterCondition with the standard toolchain Condition toolchain-common#391
• Member-Operator - KUBESAW-43: Replace the special ToolchainClusterCondition with the standard toolchain Condition member-operator#560
• Toolchain-E2E - KUBESAW-43: Replace the special ToolchainClusterCondition with the standard toolchain Condition toolchain-e2e#955
• KSCTL - KUBESAW-43: Replace the special ToolchainClusterCondition with the standard toolchain Condition kubesaw/ksctl#38

Only change is updating the dependency of API and toolchain-common

• Registration-Service - KUBESAW-43: Replace the special ToolchainClusterCondition with the standard toolchain Condition registration-service#424
• Sandbox-SRE - https://github.com/codeready-toolchain/sandbox-sre/pull/1706

[mfrancisc]

Nice Job 👍

[rsoaresd]

Hello @fbm3307 👋

All the runs of this PR failed with reached timeout of waiting for CRD memberoperatorconfigs.toolchain.dev.openshift.com to be available in the cluster and the InstallPlan to be complete.

Very likely is PR specific. At least, from this search query, it seems.

[mfrancisc]

Based on the e2e test failure:

message: 'error validating existing CRs against new CRD''s schema for "toolchainclusters.toolchain.dev.openshift.com":
      error validating toolchain.dev.openshift.com/v1alpha1, Kind=ToolchainCluster
      "toolchain-host-29071701/member-ci-op-3g617pk9-1de72.devsandboxci.devcluster.openshift.1":
      updated validation is too restrictive: [].status.conditions[0].lastProbeTime:

it seems that it doesn't allow to switch to the new Conditions type since the previous one ToolchainClusterCondition has a required field LastProbeTime which is missing in the new CRD.

[mfrancisc]

Maybe we need first to make that field optional and then migrate to the new Condition ? Not sure if that will workaround the issue.

[fbm3307]

Thanks @rsoaresd for lookinng into the errors.
@mfrancisc yes i think, will make LastProbetTime Optional first , also add the new field of LastTransitionTime then switch to new condition

[mfrancisc]

also add the new field of LastTransitionTime then switch to new condition

TBH I'm not 100% sure this is required , because adding a new filed in new CRD should be a problem , but removing a required field seems to be the issue 🤷‍♂️

[fbm3307]

looks like a flaky test
/test e2e

[fbm3307]

looks like the e2e failure is not related to this PR

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fbm3307, MatousJobanek, metlos, mfrancisc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [MatousJobanek,mfrancisc]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[fbm3307]

/test e2e

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.74%. Comparing base (97cedbf) to head (b464efa).

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #1017   +/-   ##
=======================================
  Coverage   84.74%   84.74%           
=======================================
  Files          55       55           
  Lines        4909     4909           
=======================================
  Hits         4160     4160           
  Misses        576      576           
  Partials      173      173