CRD yaml make generate updates when upgrading controller-gen in api #994
Conversation
ranakan19
requested review from
MatousJobanek,
xcoulon,
alexeykazakov,
rajivnathan,
sbryzak and
mfrancisc
as code owners
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alexeykazakov, MatousJobanek, ranakan19 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| @@ -76,6 +75,8 @@ spec: | |||
| can be included in the output. | |||
| type: string | |||
| metadata: | |||
| description: 'metadata is the standard object''s metadata. More | |||
There was a problem hiding this comment.
Extra comma? Not sure whether it'd effect anything but just thought I'd raise it
| description: 'metadata is the standard object''s metadata. More | |
| description: 'metadata is the standard object's metadata. More |
There was a problem hiding this comment.
It's a generated yaml. Not sure what API go code exactly is the source of this string but we shouldn't modify it in the CRD yaml directly :)
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #994 +/- ##
==========================================
- Coverage 84.87% 84.85% -0.02%
==========================================
Files 55 55
Lines 5066 5066
==========================================
- Hits 4300 4299 -1
- Misses 583 584 +1
Partials 183 183 |
crd changes from running make generate in api when controller-gen version updated
DO-NOT Merge
(All the PRs related to version updates need to be merged at once, but these PR are for early feedback so that there are not a lot of changes to review at once)