Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Django 3 support #290

Closed
JorneVL opened this issue Jan 21, 2020 · 3 comments
Closed

Django 3 support #290

JorneVL opened this issue Jan 21, 2020 · 3 comments
Labels
Type: Enhancement New feature or functionality change
Milestone

Comments

@JorneVL
Copy link
Contributor

JorneVL commented Jan 21, 2020

With the latest version of Wagtail, Django 3.0 is supported.
Codered CMS and related packages still uses parts that are deprecated or removed in Django 3.0.
Pull request #148 solves a part of this.

Additional context

I have created a local clone where I have fixed some parts about Django 3.0
But there are two packages that still uses removed parts of Django.
So I can't test the code.

  • django-eventtools uses python_2_unicode_compatible
  • wagtail-cache uses lru_cache

Wagtail-cache is maintained by Codered Corp, but Eventtools hasn't had a commit since 14 Aug 2018.
What is the best way to proceed this upgrade?

@JorneVL JorneVL added the Type: Enhancement New feature or functionality change label Jan 21, 2020
@vsalvino
Copy link
Contributor

Thanks for checking on this. I think the upcoming Wagtail 2.8 will support Django 3.0, so this is a timely issue.

I imagine the fixes shouldn't be too bad in coderedcms - but I think pull request #148 is somewhat abandoned. If you have a fork that fixes Django 3.0 issues, a pull request would be much appreciated!

We can handle upgrading wagtail-cache.

For django-eventtools, that will require more investigation. Hopefully they will accept a patch. Otherwise we (or somebody) would have to fork django-eventtools, which I would like to avoid at all costs.

@JorneVL
Copy link
Contributor Author

JorneVL commented Jan 22, 2020

I have created PR #291.
I have created an issue for Eventtools: gregplaysguitar/django-eventtools#32

@vsalvino
Copy link
Contributor

vsalvino commented Feb 5, 2020

Fixed by #291

@vsalvino vsalvino closed this as completed Feb 5, 2020
@vsalvino vsalvino added this to the 0.18.0 milestone Feb 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement New feature or functionality change
Projects
None yet
Development

No branches or pull requests

2 participants