Write cmake_output under build_path #222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Interesting! How come we never noticed? Is this new? The |
|
It happened because of my last change. We are not moving anymore into the
build directory, just running CMake outside of it with `-B<build_path> -H.`
hence the `cmake_output` file is "orphaned"
…On Fri, Dec 15, 2017 at 11:26 AM, Radovan Bast ***@***.***> wrote:
Interesting! How come we never noticed? Is this new? The os.path.join
paths should I think be comma-separated.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#222 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ADiXESgpUqS0fknOx19kFBKavjPotUvgks5tAp3SgaJpZM4RDsuS>
.
--
Roberto Di Remigio
|
robertodr
commented
Dec 15, 2017
autocmake/configure.py
Outdated
| @@ -75,7 +75,7 @@ def run_cmake(command, build_path, default_build_path): | |||
| sys.stderr.write(stderr) | |||
|
|
|||
| # write cmake output to file | |||
| with open('cmake_output', 'w') as f: | |||
| with open(os.path.join(build_path + 'cmake_output'), 'w') as f: | |||
There was a problem hiding this comment.
And of course you're right that it need a comma.
|
You can squash the two commits if you'd like |
|
Thanks a lot for the fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cmake_outputwas written to the root directory instead of underbuild_path.