adjust XL Fortran OMP flag; fixes #232 #233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you please look over this @robertodr? |
robertodr
reviewed
Mar 7, 2018
There was a problem hiding this comment.
Why not copy the latest FindOpenMP.cmake into a folder modules/upstream and offload all this Fortran stuff to CMake itself with find_package(OpenMP)?
|
Hmm. Yes, that would be even better. Thanks. One thing that starts to bother me a bit is the diffuse versioning in Autocmake but that is a separate issue. We need to think about it. |
|
One problem that I see with this is that FindOpenMP.cmake potentially pulls in other modules (I haven't tested this but see this happening with FindMPI.cmake. I think we should merge this since it's better than before but I think that offloading to FindOpenMP.cmake is not so trivial. |
|
Agreed that this is better than nothing.
…On Wed, Mar 7, 2018, 12:36 Radovan Bast ***@***.***> wrote:
One problem that I see with this is that FindOpenMP.cmake potentially
pulls in other modules (I haven't tested this but see this happening with
FindMPI.cmake. I think we should merge this since it's better than before
but I think that offloading to FindOpenMP.cmake is not so trivial.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#233 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ADiXEft9_T6AUvzxG--j4_IrCrHZftmZks5tb8ZFgaJpZM4SgEWC>
.
|
robertodr
approved these changes
Mar 7, 2018
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.