Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding New Scopes & Eloquent Methods. #23

Merged
merged 5 commits into from
Mar 22, 2023
Merged

Adding New Scopes & Eloquent Methods. #23

merged 5 commits into from
Mar 22, 2023

Conversation

neazk
Copy link
Contributor

@neazk neazk commented Mar 19, 2023

No description provided.

@ousid
Copy link
Member

ousid commented Mar 21, 2023

@neazk, thanks for PR. Could you add tests related to the added methods?

adding tests for the methods:
makePriorityAsHigh()
makePriorityAsNormal()
makePriorityAsLow()

and scopes:
archived()
unArchived()
@neazk neazk changed the title adding archived and unarchived scopes to the ticket model adding archived and unarchived scopes to the ticket model and adding makePriorityAsLow, makePriorityAsNormal and makePriorityAsHigh methods. Mar 21, 2023
@neazk
Copy link
Contributor Author

neazk commented Mar 21, 2023

i have added testing.

@ousid
Copy link
Member

ousid commented Mar 21, 2023

@neazk It seems some of the tests failing, can you check please?

@neazk
Copy link
Contributor Author

neazk commented Mar 21, 2023

solved

@ousid ousid changed the title adding archived and unarchived scopes to the ticket model and adding makePriorityAsLow, makePriorityAsNormal and makePriorityAsHigh methods. Adding New Scopes & Eloquent Methods. Mar 22, 2023
@ousid ousid merged commit 68c1a60 into coderflexx:main Mar 22, 2023
@ousid
Copy link
Member

ousid commented Mar 22, 2023

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants