Better name/chat filtering

[DillonB07]

I'll be using Google's Perspective API to improve the chat/username filtering. Any score greater than 70% will be blocked. We can fine-tune the percentage later if needed.

Perspective API
Perspective Docs

This will be worked on in https://github.com/DillonB07/swordbattle.io/

[codergautam]

This would be great!

[codergautam]

@DillonB07 Any progress on this, there are increased reports of people using bad/toxic names

[DillonB07]

Sorry, I’ve been a little busy with irl stuff. I’ll see if I have time to start it later today. I don’t think it should be too hard, so hopefully it’ll only take an hour or two.

…

On 1 Jun 2022, at 22:11, Coder Gautam ***@***.***> wrote: @DillonB07 <https://github.com/DillonB07> Any progress on this, there are increased reports of people using bad/toxic names — Reply to this email directly, view it on GitHub <https://github.com/codergautam/swordbattle.io/issues/120#issuecomment-1144140567>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AUAPGD7SUKZRANMQL54M7XLVM7GWLANCNFSM5WTR57ZA>. You are receiving this because you were mentioned.

[mollthecoder]

Sorry, I’ve been a little busy with irl stuff. I’ll see if I have time to start it later today. I don’t think it should be too hard, so hopefully it’ll only take an hour or two.
…
On 1 Jun 2022, at 22:11, Coder Gautam @.***> wrote: @DillonB07 https://github.com/DillonB07 Any progress on this, there are increased reports of people using bad/toxic names — Reply to this email directly, view it on GitHub <#120 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AUAPGD7SUKZRANMQL54M7XLVM7GWLANCNFSM5WTR57ZA. You are receiving this because you were mentioned.

Make sure to take your time. No need to feel rushed!

[codergautam]

Yes, I was just checking in, take your time

[DillonB07]

Thanks. I’m having a little trouble with promises and async functions, so I might try and setup a Python server on Replit to send the requests through.

…

On 2 Jun 2022, at 23:59, Coder Gautam ***@***.***> wrote: Yes, I was just checking in, take your time — Reply to this email directly, view it on GitHub <https://github.com/codergautam/swordbattle.io/issues/120#issuecomment-1145420522>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AUAPGD7JWZAL2I2AR7KJ4T3VNE4DTANCNFSM5WTR57ZA>. You are receiving this because you were mentioned.

[DillonB07]

I've spent a few hours and made no progress. I'm really confused by JS promises and asyncio. I did a little research and it really didn't help.

My issue is that I'm using fetch() to call an API I setup but when I put it in a function, it returns a pending promise. How do I get the program to wait for that promise to complete before continuing?

[DillonB07]

Anyone able to help with this please?

[codergautam]

@DillonB07 If you're putting fetch in a normal function, you would have to do something like this:

fetch('url', {
    someoptions
}).then(res => {
    res.json().then(data => {
        console.log("json recieved", data)
    }).catch(e => {
        console.log("failed to parse json", e)
    });
}).catch((e) => {
    console.log("request failed", e)
})

[codergautam]

But can you not use a replit server? It would be a pain if it goes down and I don't want to depend on other personal servers.

[DillonB07]

Yes, that's what I did @codergautam. The issue came when returning the response from the function as I get a promise not the json.

[codergautam]

Can you send me your code?

If you want to do this as a function, here's how I would do it:

async function fetchsmth() {
var res = await fetch('url', {someoptions})
var json = await res.json()
return json;
}

And then it can be called like

fetchsmth().then((json) => {
console.log("json recieved", json)
})

[DillonB07]

Oh, ok. I'll see if I can rework it and if I can't, I'll send what I have.

Thanks!

[codergautam]

Alright, also you shouldn't be needing fetch api anyways, just use the node.js client library

https://developers.perspectiveapi.com/s/docs-sample-requests (scroll down a bit to Node.js)

If you want I can try doing that

[DillonB07]

Yeah, I tried that as well.

[codergautam]

Sorry I have a few more errands to do, might take a few more hours

[DillonB07]

No problem. I’ll probably be here for a few more hours so lmk when you’re available if you want to do it today.

…

On 5 Jun 2022, at 16:42, Coder Gautam ***@***.***> wrote: Sorry I have a few more errands to do, might take a few more hours — Reply to this email directly, view it on GitHub <https://github.com/codergautam/swordbattle.io/issues/120#issuecomment-1146836275>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AUAPGD7MKT3WZZQF4XIDP2DVNTDFJANCNFSM5WTR57ZA>. You are receiving this because you were mentioned.

[codergautam]

Hey sorry I completely forgot about this can we do it tomm since I'm out of town today.

Sorry

[DillonB07]

Possibly. I’m not guaranteeing it as I’m quite busy, but I should be free 6-7PM BST tomorrow if that works for you. If you send me the code snippet that you wrote when you have time, I can try and do a little work on it myself.

…

On 6 Jun 2022, at 16:04, Coder Gautam ***@***.***> wrote: Hey sorry I completely forgot about this can we do it tomm since I'm out of town today. Sorry — Reply to this email directly, view it on GitHub <https://github.com/codergautam/swordbattle.io/issues/120#issuecomment-1147549896>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AUAPGD6MXHF2SFY6QHR25A3VNYHPLANCNFSM5WTR57ZA>. You are receiving this because you were mentioned.

[codergautam]

const { Client } = require("@conversationai/perspectiveapi-js-client");
const client = new Client(process.env.PERSPECTIVE_API_KEY);
const checkForProfanity = (word) => {
  // const result = await perspective.analyze(word, {attributes: ["unsubstantial", "spam", "toxicity"], languages: ["en"]});
  return  client.getScores(word, {languages:[ "en"]}).TOXICITY > 0.85;
};

checkForProfanity("smth bad").then((result) => {
  console.log(result);
});

Good luck!

[DillonB07]

Thanks. It’s going great! ```zsh ~/Documents/GitHub/swordbattle.io (main ✗) node . Prof undefined Connected to database Loaded 2 evolutions 36 server started Unhandled Rejection at: Promise Promise { <rejected> Error: Error: Error: Request failed with status code 400 at Client.<anonymous> (/Users/dillonbarnes/Documents/GitHub/swordbattle.io/node_modules/@conversationai/perspectiveapi-js-client/dist/api.js:104:23) at Generator.throw (<anonymous>) at rejected (/Users/dillonbarnes/Documents/GitHub/swordbattle.io/node_modules/@conversationai/perspectiveapi-js-client/dist/api.js:5:65) at processTicksAndRejections (node:internal/process/task_queues:96:5) } reason: Error: Error: Error: Request failed with status code 400 at Client.<anonymous> (/Users/dillonbarnes/Documents/GitHub/swordbattle.io/node_modules/@conversationai/perspectiveapi-js-client/dist/api.js:104:23) at Generator.throw (<anonymous>) at rejected (/Users/dillonbarnes/Documents/GitHub/swordbattle.io/node_modules/@conversationai/perspectiveapi-js-client/dist/api.js:5:65) at processTicksAndRejections (node:internal/process/task_queues:96:5) exiting cleanly... exited cleanly ``` Note to self. Never send console logs through an email.

…

On 7 Jun 2022, at 16:33, Coder Gautam ***@***.***> wrote: const { Client } = ***@***.***/perspectiveapi-js-client"); const client = new Client(process.env.PERSPECTIVE_API_KEY); const checkForProfanity = (word) => { // const result = await perspective.analyze(word, {attributes: ["unsubstantial", "spam", "toxicity"], languages: ["en"]}); return client.getScores(word, {languages:[ "en"]}).TOXICITY > 0.85; }; checkForProfanity("smth bad").then((result) => { console.log(result); }); Good luck! — Reply to this email directly, view it on GitHub <https://github.com/codergautam/swordbattle.io/issues/120#issuecomment-1148832886>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AUAPGD35LWSVSNZL6MPXCHTVN5TVTANCNFSM5WTR57ZA>. You are receiving this because you were mentioned.

[DillonB07]

That was a stupid error. My API key had a different name in my .env file 🤦
I do get this error with the snippet you sent though.

/Users/dillonbarnes/Documents/GitHub/swordbattle.io/index.js:47
checkForProfanity("smth bad").then((result) => {
                              ^

TypeError: checkForProfanity(...).then is not a function
    at Object.<anonymous> (/Users/dillonbarnes/Documents/GitHub/swordbattle.io/index.js:47:31)
    at Module._compile (node:internal/modules/cjs/loader:1097:14)
    at Object.Module._extensions..js (node:internal/modules/cjs/loader:1149:10)
    at Module.load (node:internal/modules/cjs/loader:975:32)
    at Function.Module._load (node:internal/modules/cjs/loader:822:12)
    at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:77:12)
    at node:internal/main/run_main_module:17:47

Node.js v17.4.0

And when I go to just a regular console.log(checkForProfanity('bad word')) I still have the promise issues. Sorry, but I think I might have to give up on this. My JS isn't good enough for it.

[codergautam]

Wait my bad try this:

const { Client } = require("@conversationai/perspectiveapi-js-client");
const client = new Client(process.env.PERSPECTIVE_API_KEY);
const checkForProfanity = (word) => {
  // const result = await perspective.analyze(word, {attributes: ["unsubstantial", "spam", "toxicity"], languages: ["en"]});
  return  client.getScores(word, {languages:[ "en"]}).TOXICITY > 0.85;
};

console.log(checkForProfanity("smth bad"));

[DillonB07]

That’s what I did try. It will always return false because the request hasn’t finished. Try putting swear words/phrases in it and you’ll see.

…

On 7 Jun 2022, at 19:18, Coder Gautam ***@***.***> wrote: Wait my bad try this: const { Client } = ***@***.***/perspectiveapi-js-client"); const client = new Client(process.env.PERSPECTIVE_API_KEY); const checkForProfanity = (word) => { // const result = await perspective.analyze(word, {attributes: ["unsubstantial", "spam", "toxicity"], languages: ["en"]}); return client.getScores(word, {languages:[ "en"]}).TOXICITY > 0.85; }; console.log(checkForProfanity("smth bad")); — Reply to this email directly, view it on GitHub <https://github.com/codergautam/swordbattle.io/issues/120#issuecomment-1149014331>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AUAPGD6Z7SFHUND4A7FWXLLVN6G7FANCNFSM5WTR57ZA>. You are receiving this because you were mentioned.

[codergautam]

My bad, try this one. Pretty sure this works.

const checkForProfanity = (word) => {
  // const result = await perspective.analyze(word, {attributes: ["unsubstantial", "spam", "toxicity"], languages: ["en"]});
  return new Promise((resolve, reject) => {
    try {
    resolve(client.getScores(word, {languages:[ "en"]}));
    } catch(e) {
      reject(e);
    }
  });  
};

checkForProfanity("smth bad").then((result) => {
  console.log(result);
});

[codergautam]

Moved to discussions!

[DillonB07]

Yeah, I've completely messed things up. Not got a clue what I've done, but this is open to anyone else now. Here's a few code snippets if they help:

Uses conversationai/perspectiveapi-js-client
Docs: https://developers.perspectiveapi.com/s/docs

PM me on the forum for the API key: @DillonB07

const { Client } = require("@conversationai/perspectiveapi-js-client");
const client = new Client(process.env.PERSPECTIVE_API_KEY);

const checkForProfanity = async (word, profanitySensitivity = 0.75) => {
  // const result = await perspective.analyze(word, {attributes: ["unsubstantial", "spam", "toxicity"], languages: ["en"]});
  return new Promise((resolve, reject) => {
    try {
      resolve(client.getScores(word, { languages: ["en"] }));
    } catch (e) {
      reject(e);
    }
  }).then((result) => result.TOXICITY > profanitySensitivity);
};

The above code snippet will send a return a boolean of whether the message is toxic. The sensitivity can be passed into the function as a float. It'll have a default of 0.75 but this may need to be tweaked later.

I tried to implement this in a utils.js file and then import the function in both /index.js and src/TitleScene.js. In index.js there are two places where the filtering needs to be implemented.
https://github.com/codergautam/swordbattle.io/blob/9e0a3ea0c509c40746d18bb235a947a17b83ca45/index.js#L320 and https://github.com/codergautam/swordbattle.io/blob/9e0a3ea0c509c40746d18bb235a947a17b83ca45/index.js#L623

I'm not entirely sure whether filtering is needed in src/TitleScene.js though. The username box is created in the file though.

[codergautam]

We don't need the file in titlescene, because that's sent to the client and they could potentially abuse it.

Just check on the serverside, so anything not in /src

I guess you could just put the checking function in /index.js and check whenever someone joins, or when the "go" event is recieved.

Let me know if that works, then we can figure out how to get it working with the chat