Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bad error messages when dependencies are missing #11

Open
stzokev opened this issue Feb 5, 2019 · 3 comments
Open

Bad error messages when dependencies are missing #11

stzokev opened this issue Feb 5, 2019 · 3 comments
Assignees

Comments

@stzokev
Copy link

stzokev commented Feb 5, 2019

If I don't have innoextract I get the
/var/lib/gems/2.3.0/gems/cocaine-0.5.8/lib/cocaine/command_line.rb:82:in `run': Cocaine::CommandNotFoundError (Cocaine::CommandNotFoundError)

which others have reported before. So apparently it is not optional as indicated in the instructions. Or if it is optional in some cases, a clarification might be needed.

Great tool otherwise! Thanks for your hard work!

@coderobe
Copy link
Owner

coderobe commented Feb 5, 2019

it's optional unless it's actually required for extraction. i should probably catch these errors and print a more helpful error message

@coderobe coderobe self-assigned this Feb 5, 2019
@coderobe coderobe changed the title Remove (optional) from innoextract dependency Bad error messages when dependencies are missing Feb 5, 2019
@coderobe
Copy link
Owner

coderobe commented Feb 5, 2019

Specifically, though, it will tell you

checking for innoextract... no
Install 'innoextract' on your system (required for Inno Installers)

@stzokev
Copy link
Author

stzokev commented Feb 5, 2019

Yes, but it gives similar error messages for all dependencies, and half of them are marked as optional. Knowing that, I just ignore these messages.

@coderobe coderobe mentioned this issue Feb 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants