fix(wiki-thread): load contributor adder twice

coderplanets · May 18, 2019 · bbcc20f · bbcc20f
1 parent f799312
commit bbcc20f
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 20 deletions.
diff --git a/components/ContributorList/index.js b/components/ContributorList/index.js
@@ -31,9 +31,9 @@ const ContributorList = ({ users, readOnly, addContributor }) => (
         }
         placement="bottom"
         trigger="hover"
-        key={user.id}
+        key={user.avatar}
       >
-        <AvatarLink>
+        <AvatarLink href={user.htmlUrl} target="_blank">
           <Avatar src={user.avatar} />
         </AvatarLink>
       </Popover>

diff --git a/containers/WikiThread/Contributors.js b/containers/WikiThread/Contributors.js
@@ -18,7 +18,7 @@ import {
   JoinText,
 } from './styles/contributors'
 
-import * as logic from './logic'
+import { addContributor, syncWikiFromGithub } from './logic'
 
 const Note = ({ communityRaw }) => (
   <NoteWrapper>
@@ -44,7 +44,7 @@ const Contributors = ({ isLogin, users, views, lastSync, communityRaw }) => (
       passport="root"
       fallbackProps="readOnly"
       users={users}
-      addContributor={logic.addContributor}
+      addContributor={addContributor}
     />
 
     <FootNote>
@@ -59,12 +59,7 @@ const Contributors = ({ isLogin, users, views, lastSync, communityRaw }) => (
 
       <br />
       {isLogin && (
-        <Button
-          size="small"
-          type="primary"
-          ghost
-          onClick={logic.syncWikiFromGithub}
-        >
+        <Button size="small" type="primary" ghost onClick={syncWikiFromGithub}>
           同步 wiki
         </Button>
       )}

diff --git a/containers/WikiThread/index.js b/containers/WikiThread/index.js
@@ -25,7 +25,6 @@ import {
   RightPart,
   RightPadding,
   PublishBtn,
-  MobileBottom,
 } from './styles'
 
 import { useInit, syncWarnOnClose } from './logic'
@@ -68,15 +67,6 @@ const WikiThreadContainer = ({ wikiThread }) => {
       <LeftPadding />
       <LeftPart>
         <WikiWrapper>{renderView(wikiData, curView, communityRaw)}</WikiWrapper>
-        <MobileBottom>
-          <Contributors
-            communityRaw={communityRaw}
-            isLogin={isLogin}
-            users={wikiData.contributors}
-            views={wikiData.views}
-            lastSync={wikiData.lastSync}
-          />
-        </MobileBottom>
       </LeftPart>
       <RightPart>
         <React.Fragment>