Skip to content
This repository has been archived by the owner on Mar 9, 2021. It is now read-only.

Suggest better styling for bottom section of landing page #38

Closed
M-ZubairAhmed opened this issue Oct 22, 2017 · 5 comments
Closed

Suggest better styling for bottom section of landing page #38

M-ZubairAhmed opened this issue Oct 22, 2017 · 5 comments

Comments

@M-ZubairAhmed
Copy link

M-ZubairAhmed commented Oct 22, 2017

Current status

image

Scope of improvement

Components involved

  • Subscribe section
  • Join chat section
  • Footer

Few suggestion

  • Background color of subscribe or join chat section
  • Should or should not merge subscribe in footer
  • Placement of follow us icons on center or aside to accommodate subscribe

Technology

CSS
React

Note

  • Before sending a pull request please discuss in the comments
@nrizvi
Copy link

nrizvi commented Oct 22, 2017

I think having the follow us icon in the center is fine, I think it would be cool if you could actually place the email and join chat in the same row and separate them with line break like this:

ui update

@M-ZubairAhmed
Copy link
Author

M-ZubairAhmed commented Oct 22, 2017

@nrizvi thank you for your contribution. @duttakapil what do you think?

@duttakapil
Copy link
Member

I was thinking the same, but the Discord box on the left and the Email box on the right

@M-ZubairAhmed
Copy link
Author

M-ZubairAhmed commented Oct 22, 2017

@nrizvi would you like to work on the design you suggested, if yes please send a PR with the change

  • Discord section on left
  • Email on right
  • On mobile, both sections should stack one below other while Discord section coming sooner than email one.

@M-ZubairAhmed
Copy link
Author

this discussion is moved to issue #53

This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants