Update smart_pointers_best_practices.md #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
operations C changed to A i B
ziobron
approved these changes
Sep 22, 2020
arafalski
referenced
this pull request
in arafalski/memory-management
Sep 23, 2020
operations C changed to A i B
arafalski
referenced
this pull request
in arafalski/memory-management
Oct 5, 2020
* Update smart_pointers_best_practices.md (#27) operations C changed to A i B * weak_ptr lock() updated Co-authored-by: Marcin N <19634288+niemarcin@users.noreply.github.com>
arafalski
referenced
this pull request
in arafalski/memory-management
Oct 8, 2020
Base files Added CI Revert "Added CI" This reverts commit 89e826e. Added CI Added SharedControlBlock Rule of 5 Update main.cpp Added operator*() Added dereference test case Added copying test case Added moving test case Added operator-> Added get method Added use_count method Added operator bool Added custom deleter support to SharedControlBlock Implementation of make_shared Make_shared test case Added make_shared to cmake Update main Changed function pointer to std::function Refactoring make_share test Changed function pointer to std::function - shared_ptr Shared_ptr - reset() method (#9) * Reset method * Deleted redundant reset() overload weak_ptr with tests added (#10) * Initial weak_ptr class added * Initial version of weak_ptr * Update of destructor for weak_ptr * SEGV fixed in weak_ptr * weak_ptr constructors which using shared_ptr works * Tests added, code refactored * Code correction Proper delete conditions (#13) * Pragma once * Fixed weakRefs counter * Fixed delete conditions in weak and shared ptr * Uncommented main fun * Breaking cycle dependencies * Moved cycle dependencies checking to main fun * Moved shared_ptr deleting sequence to the lambda expression * Changed lambda to private method * Moved delete sequence to private method - weak_ptr * Added shared_ptr constructor that takes weak_ptr weak_ptr lock() updated (#15) * Update smart_pointers_best_practices.md (#27) operations C changed to A i B * weak_ptr lock() updated Co-authored-by: Marcin N <19634288+niemarcin@users.noreply.github.com> Deleted redundant constexpr Explicit Homework2 (#17) * add struct of objects template * make_shared as shared_ptr friend * Implement make_shared function Leak in weak_ptr Homework2 make shared - changed idea (#18) * Changed name of std::function in controlblock * Make_shared - changed idea * Refactoring * Deleted controlblock-ut * Refactoring * Test * Revert "Refactoring" This reverts commit 97ef637. * Revert "Revert "Refactoring"" This reverts commit e842773. * Revert "Test" This reverts commit 6a2e411. * Test * test * test123
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
operations C changed to A & B