Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ref on host component #1228

Merged
merged 1 commit into from
Oct 25, 2018
Merged

Use ref on host component #1228

merged 1 commit into from
Oct 25, 2018

Conversation

pshrmn
Copy link
Contributor

@pshrmn pshrmn commented Oct 24, 2018

What kind of change does this PR introduce?

Gets rid of a console warning

What is the current behavior?

innerrefwarning

What is the new behavior?

No warning

Checklist:

  • Documentation
  • Tests
  • Ready to be merged
  • Added myself to contributors table

@pshrmn
Copy link
Contributor Author

pshrmn commented Oct 24, 2018

There is another error that I took a look at, but the fix isn't as straightforward because it messes with styles.

linkinlinkwarning

@CompuIves
Copy link
Member

Ohh, right! I'm impressed that this hasn't broken anything. Thanks for putting in this fix. Merging now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants