Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move all requests from rawgit.com to serve from jsdelivr.net #1269

Merged
merged 2 commits into from Dec 4, 2018
Merged

move all requests from rawgit.com to serve from jsdelivr.net #1269

merged 2 commits into from Dec 4, 2018

Conversation

sairam
Copy link
Contributor

@sairam sairam commented Nov 3, 2018

What kind of change does this PR introduce?
updation of urls from rawgit CDN to jsdelivr CDN

What is the current behavior?
URLs are fetched from cdn.rawgit.com

What is the new behavior?
No, change in the behavior

Checklist:

  • Documentation - N/A
  • Tests
  • Ready to be merged

Reason: rawgit.com is getting shutdown

Reason: rawgit.com is getting shutdown
@SaraVieira
Copy link
Contributor

@CompuIves Can i merge this ? :D

@SaraVieira SaraVieira closed this Dec 3, 2018
@SaraVieira SaraVieira reopened this Dec 3, 2018
@SaraVieira
Copy link
Contributor

sorry i don't know git

@CompuIves
Copy link
Member

Hmm, for some reason the PR doesn't load for me (@lbogdan?)

@CompuIves
Copy link
Member

Thanks for the contribution @sairam! Could you merge this PR with the latest master? I think then we cna merge it in. 😄

@sairam
Copy link
Contributor Author

sairam commented Dec 4, 2018

@CompuIves looks like one of the check was failing. I have not spent time looking into it

@CompuIves
Copy link
Member

That's okay! It's our IE11 check failing on CRA template, since CRA recently dropped support. Thanks for the merge, I'll take a look now!

@CompuIves
Copy link
Member

Seems like everything works! Thanks for the contribution!

@CompuIves CompuIves merged commit 1ee820a into codesandbox:master Dec 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants